Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ietf/group/colors.py, which is unused #4100

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

larseggert
Copy link
Collaborator

No description provided.

@larseggert larseggert marked this pull request as ready for review June 20, 2022 11:36
@rjsparks
Copy link
Member

rjsparks commented Jun 20, 2022

This feels like the last parts of a notable step backwards, even if we aren't going to use these particular colors.
We had been on our way to normalizing the color choice across views, particularly between the agenda and the agenda editor. Has this normalization happened a different way, or are we back to different choices being made in different parts of the code?

@larseggert
Copy link
Collaborator Author

Colors should be managed as part of the CSS, rather than via the Python code?

@rjsparks
Copy link
Member

that's reasonable - but the problem I'm pointing to (which isn't really the responsibility of this PR, but of changes leading up to it) then exists with how views use the css. I think we're diverging (Nick's agenda pages use the base colors, but darken them in a wash for instance). Have we reconciled group colors between the agenda and agenda editor yet?

@rjsparks rjsparks merged commit 86e548c into ietf-tools:main Jun 20, 2022
@larseggert larseggert deleted the remove-group-colors branch June 20, 2022 16:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants