fix: validate group type/acronym properly in admin. Fixes #4028. #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4070 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 297 297
Lines 39275 39275
==========================================
- Hits 34620 34619 -1
- Misses 4655 4656 +1
Continue to review full report at Codecov.
|
rjsparks
approved these changes
Jun 13, 2022
|
|
||
| def clean(self): | ||
| """Clean parts of the form that involve multiple fields""" | ||
| # Constrain the acronym form. Note that this doesn't look for collisions. |
There was a problem hiding this comment.
Good observation - how hard would it be to do so?
There was a problem hiding this comment.
I can't take credit for the observation - it came from the original comments - but I think it should be straightforward.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.