Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tweak the horrible code in SearchableField #3957

Merged
merged 3 commits into from
May 19, 2022

Conversation

larseggert
Copy link
Collaborator

So another corner case works.

Fixes #3940. Hopefully doesn't break anything.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3957 (95363ba) into main (cb996c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 95363ba differs from pull request most recent head 12c9580. Consider uploading reports for the commit 12c9580 to get more accurate results

@@           Coverage Diff           @@
##             main    #3957   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         297      297           
  Lines       39273    39273           
=======================================
+ Hits        34618    34619    +1     
+ Misses       4655     4654    -1     
Impacted Files Coverage Δ
ietf/utils/fields.py 91.32% <100.00%> (ø)
ietf/utils/pipe.py 82.60% <0.00%> (-4.35%) ⬇️
ietf/group/utils.py 94.66% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39525a1...12c9580. Read the comment docs.

@larseggert larseggert requested a review from rjsparks May 16, 2022 17:09
@NGPixel NGPixel changed the title Fix: Tweak the horrible code in SearchableField refactor: tweak the horrible code in SearchableField May 17, 2022
@rjsparks rjsparks merged commit fa17ddd into ietf-tools:main May 19, 2022
@larseggert larseggert deleted the fix-3940 branch May 24, 2022 07:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestones with multiple associated drafts do not render those drafts
2 participants