Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Link to reviews from search status column #3955

Merged
merged 3 commits into from
May 13, 2022

Conversation

larseggert
Copy link
Collaborator

Fixes #3953.

Also frees up some space for the now slightly larger review badges by shortening the "timeout exceeded" warnings, which are maybe not all that important.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3955 (5800b05) into main (cb996c5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3955      +/-   ##
==========================================
- Coverage   88.14%   88.14%   -0.01%     
==========================================
  Files         297      297              
  Lines       39273    39274       +1     
==========================================
- Hits        34618    34617       -1     
- Misses       4655     4657       +2     
Impacted Files Coverage Δ
ietf/doc/templatetags/ballot_icon.py 84.72% <100.00%> (-0.70%) ⬇️
ietf/doc/templatetags/ietf_filters.py 85.25% <100.00%> (ø)
ietf/doc/utils_search.py 80.12% <100.00%> (+0.12%) ⬆️
ietf/utils/pipe.py 82.60% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39525a1...5800b05. Read the comment docs.

@rjsparks rjsparks merged commit 75a32d2 into ietf-tools:main May 13, 2022
@larseggert larseggert deleted the fix-3953 branch May 24, 2022 07:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search result rows for drafts don't link to reviews specific to the draft
2 participants