Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape the ballot comments #3952

Merged
merged 1 commit into from
May 12, 2022

Conversation

larseggert
Copy link
Collaborator

I wonder if other fields that have class pasted would need to be escaped, too?

I wonder if other fields that have class `pasted` would need to be escaped, too?
@rjsparks
Copy link
Member

do you think this was a bs5 regression?
Double-escaping was a huge problem several years ago. I hope we're not back into a period of fighting that bit of annoyance.
We really should start working towards a future where things like ballots (charter, etc) are markdown...

@larseggert
Copy link
Collaborator Author

do you think this was a bs5 regression?

I don't know. It might be.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3952 (c7f2eb9) into main (cb996c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3952   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         297      297           
  Lines       39273    39273           
=======================================
  Hits        34618    34618           
  Misses       4655     4655           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb996c5...c7f2eb9. Read the comment docs.

@rjsparks rjsparks merged commit 39525a1 into ietf-tools:main May 12, 2022
@larseggert larseggert deleted the fix-ballot-escape branch May 24, 2022 07:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants