Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly linkify all current TLDs #3868

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Conversation

larseggert
Copy link
Collaborator

Fixes #3866.

Doesn't actually work, because bleach seems to have deeper issues. See mozilla/bleach#656.

@rjsparks
Copy link
Member

Note that we are on Bleach 4.1.0 until we can move off python3.6 (which is hopefully sometime next week).
The folks responding at Bleach may be testing with 5.0.0

@larseggert larseggert marked this pull request as ready for review April 23, 2022 07:27
@larseggert
Copy link
Collaborator Author

I misunderstood the bleach API; this should now work (and fix the issue).

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3868 (c88e96e) into main (92e67ac) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3868   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         297      297           
  Lines       38771    38773    +2     
=======================================
+ Hits        34115    34118    +3     
+ Misses       4656     4655    -1     
Impacted Files Coverage Δ
ietf/utils/text.py 85.10% <0.00%> (-0.30%) ⬇️
ietf/doc/templatetags/ietf_filters.py 81.35% <0.00%> (-0.06%) ⬇️
ietf/utils/templatetags/textfilters.py 100.00% <0.00%> (ø)
ietf/nomcom/utils.py 92.11% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dec52f...c88e96e. Read the comment docs.

@rjsparks rjsparks merged commit 9db1d48 into ietf-tools:main Apr 26, 2022
@larseggert larseggert deleted the fix-3866 branch April 26, 2022 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urlized email addresses are broken for several domains
3 participants