Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix a regression in #3625 #3656

Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix: Fix a regression in #3625 #3656

merged 1 commit into from
Mar 16, 2022

Conversation

larseggert
Copy link
Collaborator

Tag closed incorrectly.

@rjsparks rjsparks merged commit c2cba85 into ietf-tools:feat/bs5 Mar 16, 2022
@rjsparks
Copy link
Member

Why the newline change at the end of the file?

@larseggert
Copy link
Collaborator Author

My editor uses .editorconfig, which I think makes that happen. If we don't want final newlines trimmed, we should adjust the settings there.

@larseggert larseggert deleted the fix-base branch March 16, 2022 14:58
@rjsparks rjsparks mentioned this pull request Mar 23, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larseggert @rjsparks