Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced #3651

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

russhousley
Copy link
Collaborator

Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced. Fixes #3639.

@rjsparks
Copy link
Member

Why should this gated on the state of the document in any way?
If the secretariat or an AD (or other stream-appropriate person) wanted to change the list of addresses to "also notify" years after the document was approved in case someone added a comment to the document and they wanted to be notified, why should the tool prevent that?

@russhousley
Copy link
Collaborator Author

Once the announcement is sent, there is probably not going to be changes. That said, it would be trivial to remove the check related to the state. Notice that many other fields cannot be edited of the conflict-review is in one of the approved states.

@NGPixel NGPixel changed the title Fixes #3639 fix: Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced Mar 16, 2022
@rjsparks rjsparks self-assigned this Mar 16, 2022
@rjsparks rjsparks merged commit d40842e into ietf-tools:feat/bs5 Mar 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants