Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please delete ballot for draft-ietf-dnsop-zoneversion #7480

Closed
1 task done
cindymorgan opened this issue May 28, 2024 · 6 comments
Closed
1 task done

Please delete ballot for draft-ietf-dnsop-zoneversion #7480

cindymorgan opened this issue May 28, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@cindymorgan
Copy link
Collaborator

Describe the issue

From: "Warren Kumari" [email protected]
Subject: Whoops, wrong button on draft-ietf-dnsop-zoneversion…
To: "IESG_Secretary" [email protected], "The IESG" [email protected]
Date: Tue, 28 May 2024 10:15:34 -0700

Hi there,

I generally complete my ballot writeup while doing my AD review (i.e before IETF LC) --that way it's all fresh in my mind, etc.
This time I accidentally hit "Save and issue ballot" instead of "Save", and so there is an IESG Eval even though the document hasn't had a LC yet.

Secretariat: Can you please unissue[0] the ballot?
IESG: Can you please ignore the ballot for now? IETF LC still needs to happen…

Thanks!
W
[0]: Hey, I think it should be a real word… perhaps recall?

Code of Conduct

@cindymorgan cindymorgan added the bug Something isn't working label May 28, 2024
@wkumari
Copy link
Contributor

wkumari commented May 28, 2024

If this is hard to fix it's not the end of the world -- I've asked other ADs to not ballot yet, and, well, not balloting is easy :-)

It would be nice though if the warned you that you are about to issue a ballot for a document which has not yet had an IETF LC -- I think that it used to do this, because I'm fairly sure I've seen the warning previously...

@rjsparks
Copy link
Member

Manually removed that ballot and added a note to the document history.

@rjsparks
Copy link
Member

rjsparks commented May 29, 2024

The warning is currently issued by this:

ballot_issue_danger=bool(prev_state.slug in ['ad-eval', 'lc']),

but this particular draft was in this state at the time (prev_state is the state the document was in when the view was entered):

>>> d
<Document: draft-ietf-dnsop-zoneversion>
>>> d.get_state('draft-iesg')
<State: AD is watching>

@rjsparks
Copy link
Member

rjsparks commented May 29, 2024

The use of the watching draft-iesg state has been inconsistent between ADs, and has changed over time. Most uses of it went away when the ability to return to iesg-state idexists was added to the datatracker.

We could add watching to the above conditional, but it may have unintended consequences given other uses of that state.

@wkumari - what is your preference?

@wkumari
Copy link
Contributor

wkumari commented May 29, 2024 via email

@rjsparks
Copy link
Member

Moved the code change request into its own issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants