Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too grey #6179

Closed
1 task done
paulehoffman opened this issue Aug 21, 2023 · 6 comments · Fixed by #6213
Closed
1 task done

Too grey #6179

paulehoffman opened this issue Aug 21, 2023 · 6 comments · Fixed by #6213
Assignees
@larseggert
Labels
bug Something isn't working

Comments

@paulehoffman
Copy link

Describe the issue

The new color scheme for the Datatracker header is dark, so there is not enough contrast between the new background and the text. Please lighten it greatly.

image

Code of Conduct
@paulehoffman paulehoffman added the bug Something isn't working label Aug 21, 2023
@larseggert larseggert self-assigned this Aug 22, 2023
@larseggert
Copy link
Collaborator

This should be already fixed by #6166

@paulehoffman
Copy link
Author

As of right now, it is not, and I get the same screen shot as above. The page I'm on reports "Version 11.8.0 (release - b3a057d)"

@larseggert
Copy link
Collaborator

That's because that PR is merged but not deployed yet.

@rjsparks
Copy link
Member

You can preview the next release at dt-main.dev.ietf.org.

@paulehoffman
Copy link
Author

The pink is better, but why have any background at all? Any background color makes the text harder to read for someone. And, yes, I'm a bit bah-humbug-y about design changes...

@paulehoffman
Copy link
Author

I appreciate the color change, but I am now reopening this because now the "Report a bug" text is unreadable:
image

@paulehoffman paulehoffman reopened this Aug 24, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Aug 25, 2023
@larseggert
fix: Change color of error reporting link in menu bar
92b193d 
Fixes ietf-tools#6179
@larseggert larseggert mentioned this issue Aug 25, 2023
Merged
rjsparks pushed a commit that referenced this issue Aug 25, 2023
@larseggert
fix: Change color of error reporting link in menu bar (#6213)
b304e07 
Fixes #6179
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larseggert larseggert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change color of error reporting link in menu bar larseggert/datatracker
3 participants
@larseggert @paulehoffman @rjsparks