Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the name of the directorate reviewer for drafts #5360

Closed
1 task done
martinthomson opened this issue Mar 16, 2023 · 1 comment · Fixed by #5363
Closed
1 task done

Show the name of the directorate reviewer for drafts #5360

martinthomson opened this issue Mar 16, 2023 · 1 comment · Fixed by #5363
Assignees
@larseggert
Labels
enhancement New feature or request

Comments

@martinthomson
Copy link
Contributor

Description

I'm looking at the directorate reviews for https://datatracker.ietf.org/doc/draft-ietf-6man-rfc6874bis/ (which happens to have a nice collection of options) and I found myself wondering "who said that?" Then I realized that it was me. The current format is "$DIRECTORATE $stage review (of -$vv)? ($REVIEW_OUTCOME)". Maybe adding "by $PERSON" might help contextualize in some cases.

Code of Conduct
@martinthomson martinthomson added the enhancement New feature or request label Mar 16, 2023
@larseggert larseggert self-assigned this Mar 17, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Mar 17, 2023
@larseggert
fix: Add reviewer name to review assignment summary
283be66 
Fixes ietf-tools#5360
@larseggert larseggert mentioned this issue Mar 17, 2023
Merged
@rjsparks
Copy link
Member

We'll try this, but note that it makes a noisy page even noisier.
It's an antipattern that we put all the things all the time on every page.

rjsparks pushed a commit that referenced this issue Mar 20, 2023
@larseggert
fix: Add reviewer name to review assignment summary (#5363)
8f8a348 
* fix: Add reviewer name to review assignment summary

Fixes #5360

* Address code review

* Fix test harder
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larseggert larseggert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add reviewer name to review assignment summary larseggert/datatracker
3 participants
@martinthomson @larseggert @rjsparks