Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Holder is empty when draft is in IESG State "Publication Requested" #5227

Closed
1 task done
DavidSchinazi opened this issue Feb 28, 2023 · 4 comments · Fixed by #6854
Closed
1 task done

Action Holder is empty when draft is in IESG State "Publication Requested" #5227

DavidSchinazi opened this issue Feb 28, 2023 · 4 comments · Fixed by #6854
Assignees
@pselkirk
Labels
accepted bug Something isn't working component: doc/ medium

Comments

@DavidSchinazi
Copy link
Contributor

Describe the issue

First off, thank you so much for the Action Holder feature, it's amazing. I think I might have found a bug in it though. When a WG chair requests publication on a document, the Action Holder field appears but it starts off empty. Would it be possible to have it start filled in with the name from the "Responsible AD" field instead? I noticed a draft stuck in this state and a few of us were confused as we didn't know who to ask.

Code of Conduct
@DavidSchinazi DavidSchinazi added the bug Something isn't working label Feb 28, 2023
@larseggert
Copy link
Collaborator

I just tried this in my dev instance and I cannot reproduce. When I pub-request a doc, the responsible AD becomes the action holder.

@rjsparks
Copy link
Member

@DavidSchinazi to help with diagnostics which document did you notice this on?

Fwiw, I can reproduce this using an EDM document in a dev instance (IAB program instead of WG) - after pubreq:
image

@rjsparks
Copy link
Member

I can reproduce this with a WG document as well.

@DavidSchinazi
Copy link
Contributor Author

draft-ietf-babel-mac-relaxed

pselkirk added a commit to pselkirk/datatracker that referenced this issue Dec 28, 2023
@pselkirk
fix: Properly set AD as action holder when submitting to IESG for pub…
92c0770 
…lication (ietf-tools#5227)

The clear intent of `to_iesg` is that
a) the document AD should be the group AD, if not already set, and
b) the document Action Holder should be the document AD;
but there was an order-of-operation error,
such that the Action Holder remained empty.
@pselkirk pselkirk mentioned this issue Dec 28, 2023
Merged
rjsparks pushed a commit that referenced this issue Jan 3, 2024
@pselkirk
fix: Properly set AD as action holder when submitting to IESG for pub…
b445119 
…lication (#6854)

* fix: Properly set AD as action holder when submitting to IESG for publication (#5227)

The clear intent of `to_iesg` is that
a) the document AD should be the group AD, if not already set, and
b) the document Action Holder should be the document AD;
but there was an order-of-operation error,
such that the Action Holder remained empty.

* refactor: Don't take values out of the parent scope, don't insert values into the parent scope

* refactor: Streamline DocEvent creation
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pselkirk pselkirk

Labels
accepted bug Something isn't working component: doc/ medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Properly set AD as action holder when submitting to IESG for publication pselkirk/datatracker
4 participants
@larseggert @DavidSchinazi @pselkirk @rjsparks