Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I-D PDFs have "Updates:", "Obsoletes:", and "Authors:" printed vertically in header #5073

Closed
1 task done
ajeanmahoney opened this issue Feb 2, 2023 · 3 comments · Fixed by #5078
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@ajeanmahoney
Copy link
Collaborator

Describe the issue

The headers of multiple I-D PDFs have the labels "Obsoletes:", "Updates:", and "Authors:" printed one letter per line. Examples include the PDFs of documents on the IESG Telechat agenda. In particular, https://datatracker.ietf.org/doc/pdf/draft-ietf-elegy-rfc8989bis-04:

Workgroup: ELEGY
Internet-Draft: draft-ietf-elegy-rfc8989bis-04
O          8989 (if approved)
        b
        s
        o
        l
        e
        t
        e
        s
        :
U      8713 (if approved)
     p
     d
     a
     t
     e
     s
     :
 Published: 25 January 2023
Intended Status: Best Current Practice
Expires: 29 July 2023
A     M. Duke
     uGoogle LLC
     t
     h
     o
     r
     s
     :

Code of Conduct

@ajeanmahoney ajeanmahoney added the bug Something isn't working label Feb 2, 2023
@larseggert
Copy link
Collaborator

CC @martinthomson

@martinthomson
Copy link
Contributor

Ooo boy, that's pretty great. What you are looking at there is a bug in the PDF renderer.

I wonder why this is happening there and not elsewhere? It's apparent that the space is large enough, but the weasyprint rendered has decided to go bananas and fold each character onto a new line.

(In case you were looking for fast turnaround, that's not happening on my part. It's going to be at least two weeks before I have any time at all for this stuff.)

@martinthomson
Copy link
Contributor

I will provide some hints. These labels use CSS "content" rules in a ::before pseudo-element. These are drawn into a block that has a negative margin. The renderer clearly thinks that the subsequent characters need to be drawn on successive lines.

My guess is that these are an interaction between the above, the lack of an explicit width on the element (which might lead to it being sized as zero width) and the introduction of the overflow-wrap: break-word rule (@larseggert will know what this is for). One of two options might be worth investigating:

  • Add an explicit width for each of these elements. Each would require its own special width.
  • Disable the overflow-wrap rule for dd::before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants