Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bibxml reference files no longer show all the name information #4384

Closed
1 task done
cabo opened this issue Aug 29, 2022 · 2 comments · Fixed by #4470
Closed
1 task done

bibxml reference files no longer show all the name information #4384

cabo opened this issue Aug 29, 2022 · 2 comments · Fixed by #4470
Labels

Comments

@cabo
Copy link
Collaborator

cabo commented Aug 29, 2022

Describe the issue

ietf-tools/bibxml-service#280

Only fullname seems to be filled in any more. surname or initials seem to be missing now.
This creates incorrect guesses as to what the surname and what the initial-generating names are.

This seems to have happened around August 18 to 20

Code of Conduct

@rjsparks
Copy link
Member

Bringing the rest of the discovery into this issue (pulling text from https://mailarchive.ietf.org/arch/msg/tools-discuss/4C8uDbOjs-o97ivlKfDlA2F33HI>):

This didn't change recently - it's been this way for years, but it is a bug.

https://datatracker.ietf.org/doc/bibxml3/draft-ietf-tsvwg-l4s-arch.xml

and

https://datatracker.ietf.org/doc/bibxml3/draft-ietf-tsvwg-l4s-arch-20.xml

return different results (specifically around author name decomposition), which is not expected.
(Nothing special about that draft - this same behavior will occur with any draft).

This bug is rooted in the code-path passing the Document object to the template in one case, and the most recent DocHistory object in the other, and these things have different knowledge of the Submission object that led to the version. It's not clear to me why we have this distinction in this particular code flow and that the template cares, and I'll look to see if it can be simplified.

I'm speculating that if we have the submission object there's more trust in the freshness of the author names, but why we grab initials and lastname in one path and not the other is very much not obvious.

That said, there is rising awareness that trying to calculate initials and "last name" doesn't work across all our contributing cultures, and in the long run, we may stop trying.

@bbriscoe
Copy link

bbriscoe commented Sep 8, 2022

Thanks @rjsparks.

Despite the apparent desire to move from "surname, initials" to "fullname" in references, that's a policy question, which may take some time working through "the committee stages".

So, yes, it's important to fix this mechanism problem so that the current "surname, initials" policy works. Because I'm sure some people with names that don't conform to the assumptions will have tried to lever their name into these fields in a way that produces their desired outcome under the current policy. Thank you for confirming that you're making progress on that yourself (with the help of the clues that Carsten unearthed). Someone knowledgeable taking responsibility was the part that was previously missing.

rjsparks added a commit to rjsparks/datatracker that referenced this issue Sep 16, 2022
Fixes ietf-tools#4384.

Refactors bibxml production to remove repeated logic.

Abandons the half-implemented idea that returning information
from the Submission object might be better than the Document or
DocHistory objects.
rjsparks added a commit that referenced this issue Sep 19, 2022
* fix: return same bibxml for versioned and versionless references

Fixes #4384.

Refactors bibxml production to remove repeated logic.

Abandons the half-implemented idea that returning information
from the Submission object might be better than the Document or
DocHistory objects.

* fix: test for None with `is not` and simplify choice from multiple qs objects

Addresses review comments.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants