Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary directories for tests created in project root #3592

Closed
jennifer-richards opened this issue Mar 8, 2022 · 5 comments
Closed

temporary directories for tests created in project root #3592

jennifer-richards opened this issue Mar 8, 2022 · 5 comments

Comments

@jennifer-richards
Copy link
Member

When running tests, a bunch of temporary directories are created in the project root:

$ ls -d tmp*
tmp-bibxml_base_path-submittests-dir/                 tmp-rfc_path-submittests-dir/
tmp-idsubmit_staging_path-submittests-dir/            tmp-storage-meetinghosttests-dir/
tmp-internet_all_drafts_archive_dir-submittests-dir/  tmp-submit_yang_catalog_dir-submittests-dir/
tmp-internet_draft_archive_dir-submittests-dir/       tmp-submit_yang_draft_model_dir-submittests-dir/
tmp-internet_draft_path-submittests-dir/              tmp-submit_yang_iana_model_dir-submittests-dir/
tmp-nomcom-public-keys-dir/                           tmp-submit_yang_rfc_model_dir-submittests-dir/

Some of these are not cleaned up (see #3520), but they also interact poorly with PyCharm's external file detection. When tests are running, a window pops up offering to add the files to version control, causing annoyance.

If these temporary directories could be placed in a common subdirectory (tmp/ or test/, perhaps) that can be excluded from the project in the IDE, this would allow the sometimes useful external file alert to be enabled without the annoyance of repeated suggestions to add throwaway test files to the project.

@rjsparks
Copy link
Member

rjsparks commented Mar 8, 2022

Is this specific to the dev container, or to the bs5 branch?
For native install, most of these things do land in (project-root)/tmp, except for one which (bizarrely) ends up at env/tmp-storage-meetinghosttests-dir.

@jennifer-richards
Copy link
Member Author

I'm not sure. Other than the two mentioned in #3520, I hadn't noticed it before but I probably had disabled the "add external files" alert. I don't think it's specific to the bs5 branch but perhaps the dev container because I've done most of my work there. I'll try it over here with a native install.

@jennifer-richards
Copy link
Member Author

On my native install with a virtual env, they end up in venv/tmp-*, which is better (the venv/ directory is already excluded) so it just seems to be the dev container.

@jennifer-richards
Copy link
Member Author

Oh- except that tmp-nomcom-public-keys-dir is created in the project root even after everything else is in venv/

@rjsparks
Copy link
Member

rjsparks commented Sep 9, 2022

I think this is OBE - reopen if it is not.

@rjsparks rjsparks closed this as completed Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants