Skip to content

Commit

Permalink
fix: use rsab mailtrigger for To in ballot position email (#7868)
Browse files Browse the repository at this point in the history
  • Loading branch information
rjsparks authored Aug 28, 2024
1 parent 1f6db0f commit 73968dc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ietf/doc/tests_ballot.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,9 @@ def test_cannot_edit_position_as_pre_ad(self):
r = self.client.post(url, dict(position="discuss", discuss="Test discuss text"))
self.assertEqual(r.status_code, 403)

# N.B. This test needs to be rewritten to exercise all types of ballots (iesg, irsg, rsab)
# and test against the output of the mailtriggers instead of looking for hardcoded values
# in the To and CC results. See #7864
def test_send_ballot_comment(self):
ad = Person.objects.get(user__username="ad")
draft = WgDraftFactory(ad=ad,group__acronym='mars')
Expand Down
2 changes: 2 additions & 0 deletions ietf/doc/views_ballot.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,8 @@ def build_position_email(balloter, doc, pos):

if doc.stream_id == "irtf":
addrs = gather_address_lists('irsg_ballot_saved',doc=doc)
elif doc.stream_id == "editorial":
addrs = gather_address_lists('rsab_ballot_saved',doc=doc)
else:
addrs = gather_address_lists('iesg_ballot_saved',doc=doc)

Expand Down

0 comments on commit 73968dc

Please sign in to comment.