Repository navigation
Carousel for web #30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { useRef, useState } from "react"; | ||
| import { | ||
| Dimensions, | ||
| } from "react-native"; | ||
| import Carousel from "react-native-reanimated-carousel"; | ||
|
|
||
| import { View } from "@/components/theme/Themed"; | ||
| import { stylesFn } from "@/styles/InfluencerCard.styles"; | ||
| import { useTheme } from "@react-navigation/native"; | ||
| import RenderMediaItem from "./render-media-item"; | ||
|
|
||
| interface CarouselProps { | ||
| data: any[]; // TODO: Add specific type | ||
| onImagePress?: (data: any) => void; | ||
| } | ||
|
Comment on lines
+12
to
+15
There was a problem hiding this comment. 🛠️ Refactor suggestion Replace The interface MediaItem {
uri: string;
type: 'image' | 'video';
thumbnail?: string;
}
interface CarouselProps {
data: MediaItem[];
onImagePress?: (uri: string) => void;
} |
||
|
|
||
| const CarouselNative: React.FC<CarouselProps> = ({ | ||
| data, | ||
| onImagePress, | ||
| }) => { | ||
| const [currentIndex, setCurrentIndex] = useState(0); | ||
| const [isPlaying, setIsPlaying] = useState(true); | ||
| const [isSwiping, setIsSwiping] = useState(false); | ||
|
|
||
| const videoRefs = useRef<{ [key: number]: any }>({}); | ||
|
|
||
| const theme = useTheme(); | ||
| const styles = stylesFn(theme); | ||
|
|
||
| const handleIndexChange = (index: number) => { | ||
| setCurrentIndex(index); | ||
| setIsSwiping(true); | ||
| // Reset swiping state after a short delay | ||
| setTimeout(() => setIsSwiping(false), 150); | ||
| Object.values(videoRefs.current).forEach((videoRef) => { | ||
| if (videoRef && videoRef.seek) { | ||
| videoRef.seek(0); | ||
| setIsPlaying(false); | ||
| } | ||
| }); | ||
| }; | ||
|
Comment on lines
+35
to
+41
There was a problem hiding this comment. 🛠️ Refactor suggestion Improve video ref handling with optional chaining and cleanup. The video ref access could be safer and should be cleaned up on unmount: // Inside component:
useEffect(() => {
return () => {
// Cleanup video refs on unmount
Object.values(videoRefs.current).forEach((videoRef) => {
videoRef?.seek?.(0);
});
};
}, []);
// In handleIndexChange:
Object.values(videoRefs.current).forEach((videoRef) => {
videoRef?.seek?.(0);
setIsPlaying(false);
});🧰 Tools🪛 Biome[error] 36-36: Change to an optional chain. Unsafe fix: Change to an optional chain. (lint/complexity/useOptionalChain) |
||
|
|
||
| const handleImagePress = (uri: string) => { | ||
| if (!isSwiping) { | ||
| if (onImagePress) { | ||
| onImagePress(uri); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <View style={styles.carouselContainer}> | ||
| <Carousel | ||
| loop | ||
| width={Dimensions.get("window").width - 45} | ||
| height={250} | ||
| data={data} | ||
| renderItem={({ item, index }) => ( | ||
| <RenderMediaItem | ||
| handleImagePress={handleImagePress} | ||
| index={index} | ||
| item={item} | ||
| videoRefs={videoRefs} | ||
| /> | ||
| )} | ||
| onSnapToItem={handleIndexChange} | ||
| style={{ | ||
| padding: 10, | ||
| }} | ||
| /> | ||
|
|
||
| <View style={styles.indicatorContainer}> | ||
| {data.map((_: any, index: any) => ( | ||
| <View | ||
| key={index} | ||
| style={[ | ||
| styles.indicatorDot, | ||
| currentIndex === index && styles.activeDot, | ||
| ]} | ||
| /> | ||
| ))} | ||
| </View> | ||
| </View> | ||
| ); | ||
| }; | ||
|
|
||
| export default CarouselNative; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve type safety in onImagePress handler.
The
anytype and TODO comment suggest room for improvement:Consider this improvement: