Skip to content

Bugfix/make-brands-perfect - #173

Merged
rahul-sinha1908 merged 2 commits into
masterfrom
bugfix/make-brands-perfect
Aug 12, 2025
Merged

rahul-sinha1908 merged 2 commits into
masterfrom
bugfix/make-brands-perfect

Conversation

@rahul-sinha1908

@rahul-sinha1908 rahul-sinha1908 commented Aug 12, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • More reliable drawer open/close behavior, including closing after brand change.
    • Improved Explore Influencers layout responsiveness to prevent clipping and ensure full-bleed presentation.
    • Bottom sheet now uses default backdrop for more consistent appearance.
  • Refactor

    • Simplified sizing and layout calculations for influencer carousel and container.
    • Streamlined drawer control logic for more predictable toggling.
  • Chores

    • Updated shared UI components to the latest revision.

@coderabbitai

coderabbitai Bot commented Aug 12, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces a pub-sub mechanism (OpenDrawerSubject) for opening/closing the drawer in DrawerMenuContent and DrawerToggleButton. Simplifies layout and sizing in explore-influencers by removing custom bottom sheet backdrop and using explicit full-size styles. Updates the shared-uis submodule pointer.

Changes

Cohort / File(s) Summary of changes
Drawer pub-sub integration
components/drawer-layout/DrawerMenuContent.tsx, components/ui/drawer-toggle-button/DrawerToggleButton.tsx
Replaces DrawerActions-based close/open with OpenDrawerSubject: DrawerMenuContent closes via OpenDrawerSubject.next(false); DrawerToggleButton opens via OpenDrawerSubject.next(true). Removes unused navigation hook in toggle button.
Explore Influencers layout adjustments
components/explore-influencers/index.tsx
Removes BottomSheetBackdrop and related renderBackdrop. Introduces computed width and height state; applies full-width/height container styles with flex:1 and minHeight:0. Updates CarouselScroller to use computed dimensions.
Submodule pointer update
shared-uis
Updates submodule commit from 7450037… to b526a27…. No in-repo code changes.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant DTB as DrawerToggleButton
  participant OMS as OpenDrawerSubject
  participant DL as DrawerLayout

  U->>DTB: Tap toggle
  DTB->>OMS: next(true)
  OMS-->>DL: open drawer
Loading
sequenceDiagram
  participant U as User
  participant DMC as DrawerMenuContent
  participant OMS as OpenDrawerSubject
  participant DL as DrawerLayout

  U->>DMC: Change brand
  DMC->>OMS: next(false)
  OMS-->>DL: close drawer
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • dev-rathore
  • Manan-Sharma-5

Poem

I thump my paws—flip, flap—open sesame, hooray!
A subject whispers “true,” and drawers glide our way.
Backdrops hop away; the carousel spins tight—
Full-width meadows stretch in pixel-light.
Commit carrots bundled, fresh and neat—
Another nibble of code, delightfully sweet. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e934262 and f3cdcc8.

📒 Files selected for processing (4)
  • components/drawer-layout/DrawerMenuContent.tsx (2 hunks)
  • components/explore-influencers/index.tsx (2 hunks)
  • components/ui/drawer-toggle-button/DrawerToggleButton.tsx (1 hunks)
  • shared-uis (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/make-brands-perfect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahul-sinha1908
rahul-sinha1908 merged commit fb38db1 into master Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant