Skip to content

Bugfix/make-brands-perfect - #138

Merged
rahul-sinha1908 merged 7 commits into
masterfrom
bugfix/make-brands-perfect
Jun 17, 2025
Merged

rahul-sinha1908 merged 7 commits into
masterfrom
bugfix/make-brands-perfect

Conversation

@rahul-sinha1908

@rahul-sinha1908 rahul-sinha1908 commented Jun 17, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Introduced a modal prompting iOS web users to download the app, which appears after a short delay if the app is not installed.
    • Added a utility to handle deep linking and app store redirection across platforms.
  • Enhancements

    • Improved notification cards with clearer navigation, visual distinction for read/unread states, and a more streamlined interaction.
    • Updated notification list rendering for better performance and consistency.
    • Refined images and messaging in authentication-related screens for a more polished appearance.
    • Added a new component to display the download prompt modal.
  • Bug Fixes

    • Adjusted navigation and session logic to enhance user flow for unauthenticated users.
  • Chores

    • Updated shared library and constants references to the latest versions.
  • Refactor

    • Removed unused notification creation and sending logic from contexts and hooks.
    • Cleaned up and reorganized notification-related code for maintainability.

@coderabbitai

coderabbitai Bot commented Jun 17, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a new cross-platform "Download App" modal for iOS users, adjusts notification handling by removing notification creation and sending logic, and refactors notification UI components for improved interaction. Several images and styles in authentication screens are updated, and some context and hook usages are streamlined or removed.

Changes

File(s) Change Summary
app/(auth)/lets-start.tsx, app/(auth)/wrong-app.tsx Updated image sources, adjusted image sizes, added border radius and margin, and reworded alert text.
app/(main)/(drawer)/(secondary)/applications.tsx, hooks/request/use-applications.tsx Removed usage of useAuthContext and useNotificationContext hooks and related notification logic.
app/_layout.tsx Added DownloadApp component to layout and changed unauthenticated redirect from /pre-signin to /lets-start.
components/NotificationCard.tsx Refactored to remove avatar, changed navigation logic, unified action on card press, added loading state, and updated styles.
components/notifications/index.tsx Switched from ScrollView to FlatList for notifications, passed new type prop, and commented out avatar prop.
contexts/notification-context.provider.tsx Removed notification creation/sending functions, added NotficationTypesToHandle array, and simplified cleanup logic.
components/download/DownloadAppModal.tsx Added new modal component prompting users to download the app, with deep-link and theming support.
components/download/index.tsx, components/download/index.native.tsx Added cross-platform DownloadApp component: web version shows modal for iOS users, native version renders nothing.
utils/deeplink.ts Added handleDeepLink utility for platform-specific deep linking and app store fallback.
shared-constants, shared-libs Updated subproject commit references.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DownloadApp
    participant DownloadAppModal
    participant handleDeepLink
    participant AppStore

    User->>DownloadApp: Visits site (iOS, not standalone)
    DownloadApp->>DownloadAppModal: Show modal after delay
    User->>DownloadAppModal: Clicks "Download App Now"
    DownloadAppModal->>handleDeepLink: Trigger deep link
    alt App installed
        handleDeepLink->>User: Open app via deep link
    else App not installed
        handleDeepLink->>AppStore: Open App Store URL
    end
Loading

Possibly related PRs

Suggested reviewers

  • Manan-Sharma-5

Poem

🐇
A modal hops in with a cheerful cheer,
"Download the app, iOS friends, right here!"
Notifications now sleeker,
With avatars much meeker,
And deep links that leap—no bugs to fear!
Hoppity hop, the updates appear!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef2de21 and 1e44eb5.

⛔ Files ignored due to path filters (1)
  • assets/images/wrong-app.png is excluded by !**/*.png
📒 Files selected for processing (14)
  • app/(auth)/lets-start.tsx (2 hunks)
  • app/(auth)/wrong-app.tsx (2 hunks)
  • app/(main)/(drawer)/(secondary)/applications.tsx (0 hunks)
  • app/_layout.tsx (3 hunks)
  • components/NotificationCard.tsx (3 hunks)
  • components/download/DownloadAppModal.tsx (1 hunks)
  • components/download/index.native.tsx (1 hunks)
  • components/download/index.tsx (1 hunks)
  • components/notifications/index.tsx (2 hunks)
  • contexts/notification-context.provider.tsx (4 hunks)
  • hooks/request/use-applications.tsx (1 hunks)
  • shared-constants (1 hunks)
  • shared-libs (1 hunks)
  • utils/deeplink.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahul-sinha1908
rahul-sinha1908 merged commit 654f2b2 into master Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant