-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/generate pattern docs merge #52
Conversation
…isobar into feature/generate-pattern-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR - thanks for all your work on this! The output is fantastic and will make reading the documentation a much nicer experience. Great code quality and clarity too.
I think it would be great to integrate your new logic into the main generate-docs
script, so we would have simply:
generate-docs.py --library # generates the pattern library including markdown index
generate-docs.py --readme # generates the readme
generate-docs.py --all # generates both
Feel free to restructure/refactor/throw away elements of my old generate-docs code.
It would also be great to have an index for each pattern category - auto-generating an index page for (e.g) /patterns/chance/index.md
that contains an index of each class within each category, just a list of bulletpoints with its one-line description and a link to the pattern documentation page.
Added a few comments inline, but it's mostly fairly cosmetic stuff and a few tips.
Going to get on the above changes over the weekend and I'll throw a progress update in here on Sunday |
I'm getting the index files going now, but I wanted to confirm for the |
@loparcog Let's switch to writing the files directly, much simpler usage that way. Might be a bit more regex-fu needed to overwrite only the relevant part of the README! |
Newest push has a pretty big load of things added in
|
@loparcog Looking and working great! 🎉 Love the index pages and class ordering, and auto-generated examples listing. A few last things, all cosmetic / tidyups really:
Then all good to go. Looking forward to publishing the new docs! |
Merged with master, generating docs seems to work without issue