Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sbc doc links not pointing to new controller action #4344

Closed
wants to merge 2 commits into from

Conversation

RyanEddyIC
Copy link
Contributor

@RyanEddyIC RyanEddyIC commented Aug 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket:
108681

A brief description of the changes

Current behavior:
SBC links are broken after filtering during plan shopping.

New behavior:
SBC links are directing to the newly refactored product_sbc_download action.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

polographer
polographer previously approved these changes Aug 20, 2024
utkarsh7989
utkarsh7989 previously approved these changes Aug 20, 2024
Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants