This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Adding a fix for lcov/gcc8 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bug: linux-test-project/lcov#38
|
Job Documentation on fc4ae15 wanted to post the following: View the site here This comment will be updated on new commits. |
Latest Lcov includes a makefile now. Use that. Append path to llvm's bin directory instead of pre-prending when loading the the GCC module. This is necessary due in part to the addition of clang's linker we now build. Fix that pesky issue when urls.txt is missing, conda create environment fails, unless you own the conda installation.
Once you set a path using modules, say with append-path. But then another module says to prepend-path that same path, Modules does not alter said path. So, our GCC module, while needing to be loaded when Clang is loaded, conflicts with our path requirements. Thankfully we no longer need the clang-formatter. Remove append-path.
Fix clobbering issue of a users bash profile for OS X.
Remove the no longer necessary jit patch.
The __Atomic patch supplied by homebrew is for GCC 8.3.0. Let us try to build that version instead.
|
Merging even though this is reporting failure. This is due to the moose group needs a failing pr into moose, with this error, in order to troubleshoot it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug: linux-test-project/lcov#38