Re-enable a mix of nodal and node-face constraints #31800
+310
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsayad
force-pushed
the
investigate-mixed-constraints
branch
from
0be4ae4 to
2d2f5ce
Compare
lindsayad
changed the title
lindsayad
changed the title
lindsayad
force-pushed
the
investigate-mixed-constraints
branch
2 times, most recently
from
7855b88 to
b6c446e
Compare
Contributor
|
Job Documentation, step Docs: sync website on 3d65508 wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Job Coverage, step Generate coverage on 3d65508 wanted to post the following: Framework coverage
Modules coverageSolid mechanics
Thermal hydraulics
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lindsayad
force-pushed
the
investigate-mixed-constraints
branch
from
b6c446e to
6ece4bf
Compare
lindsayad
requested review from
bwspenc,
dschwen,
jiangwen84,
joshuahansel and
roystgnr
as code owners
Member
Author
|
SAM patch is at https://git-nse.egs.anl.gov/SAM/SAM/-/merge_requests/1133 |
GiudGiud
reviewed
Oct 29, 2025
modules/solid_mechanics/test/tests/mixed-constraint-types/nodal-plus-node-face-constraints.i
Show resolved
Hide resolved
lindsayad
force-pushed
the
investigate-mixed-constraints
branch
from
6ece4bf to
3d65508
Compare
GiudGiud
approved these changes
Oct 29, 2025
GiudGiud
reviewed
Oct 29, 2025
| input = nodal-plus-node-face-constraints.i | ||
| run_sim = True | ||
| requirement = 'The system shall be able to compute a perfect Jacobian for a mix of nodal and node-face constraints.' | ||
| difference_tol = 1e2 |
Contributor
There was a problem hiding this comment.
this is too high no? we usually use 1e8 less than this
Member
Author
There was a problem hiding this comment.
difference tolerance is meaningless. It scales with things like Young's modulus
GiudGiud
reviewed
Oct 29, 2025
modules/solid_mechanics/test/tests/mixed-constraint-types/nodal-plus-node-face-constraints.i
Show resolved
Hide resolved
Contributor
|
Job Test, step Results summary on 3d65508 wanted to post the following: Framework test summaryCompared against e0c9988 in job civet.inl.gov/job/3341939. Removed testsAdded testsRun time changesModules test summaryCompared against e0c9988 in job civet.inl.gov/job/3341939. Removed testsAdded tests
Run time changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31804