Delete full monolithic solver & re-organize problems using lambdas #31785

kyriv1980 · 2025-10-24T20:38:40Z

This Pr resolves issues #31044, #30037, #31799 which:

Fix a bug with the crossflow aux variable population inside the implicit solver and regold as needed.
Clean-up and finalize the implicit solver (remove the full-monolithic method) since we opt to lag the enthalpy solution.
Some cosmetic/readability improvements.

This PR is an improved version of : #31500

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

modules/subchannel/src/problems/SubChannel1PhaseProblem.C

moosebuild · 2025-10-25T00:00:44Z

Job Documentation, step Docs: sync website on ce6ccf5 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2025-10-25T02:16:27Z

Job Coverage, step Generate coverage on ce6ccf5 wanted to post the following:

Framework coverage

	ac8805	#31785 ce6ccf
	Total	Total	+/-	New
Rate	85.97%	85.97%	-0.00%	-
Hits	124979	124978	-1	0
Misses	20389	20390	+1	0

Diff coverage report

Full coverage report

Modules coverage

Subchannel

	ac8805	#31785 ce6ccf
	Total	Total	+/-	New
Rate	94.74%	94.04%	-0.70%	100.00%
Hits	6030	5881	-149	145
Misses	335	373	+38	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md

modules/subchannel/test/tests/problems/SFR/sodium-19pin/gold/test19_monolithic_out.csv

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md

modules/subchannel/src/problems/SubChannel1PhaseProblem.C

modules/subchannel/src/problems/TriSubChannel1PhaseProblem.C

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md

modules/subchannel/src/problems/SubChannel1PhaseProblem.C

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md

modules/subchannel/src/problems/SubChannel1PhaseProblem.C

moosebuild · 2025-10-29T21:12:12Z

Job GCC min debug on df34e81 : invalidated by @kyriv1980

GiudGiud

looks good to me

@tanoret there are changes in the validation suite, do you want to look this over?

modules/subchannel/src/problems/SubChannel1PhaseProblem.C

moosebuild · 2025-10-30T16:13:13Z

Job Docker moose-dev-openmpi on f15c50f : invalidated by @kyriv1980

moosebuild · 2025-10-30T16:13:39Z

Job Apptainer moose-openmpi on f15c50f : invalidated by @kyriv1980

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md

moosebuild · 2025-11-07T20:17:11Z

Job Python 3.11 on d06e97b : invalidated by @kyriv1980

tanoret

All good for the CSV. All changes are within experimental uncertainties of the associated tests.

modules/subchannel/test/tests/problems/Lead-LBE-19pin/gold/test_LEAD-19pin_out.csv

modules/subchannel/test/tests/problems/psbt/gold/psbt_monolithic_out.csv

modules/subchannel/validation/Blockage/THORS/gold/FFM-3A_out.csv

modules/subchannel/validation/PNNL_12_pin/steady_state/gold/2X6_ss_out.csv

modules/subchannel/validation/Toshiba_37_pin/gold/toshiba_37_pin_out.csv

modules/subchannel/validation/psbt/psbt_ss/gold/psbt_out.csv

moosebuild · 2025-11-08T02:00:55Z

Job Test, step Results summary on ce6ccf5 wanted to post the following:

Framework test summary

Compared against ac88058 in job civet.inl.gov/job/3368843.

Removed tests

Added tests

Run time changes

Modules test summary

Compared against ac88058 in job civet.inl.gov/job/3368843.

Removed tests

Test	Time (s)
`subchannel/test:problems/SFR/sodium-19pin.test_full_monolithic`	1.67
`subchannel/test:problems/psbt.psbt_regression_test_full_monolithic_staggered`	1.46
`subchannel/test:problems/psbt.psbt_regression_test_full_monolithic`	1.31

Added tests

Run time changes

Test	Base (s)	Head (s)	+/-
`subchannel/validation/ORNL_19_pin.ORNL-19`	10.63	3.35	-68.45%

GiudGiud · 2025-11-08T16:46:12Z

great cleanup

chatgpt-codex-connector bot reviewed Oct 24, 2025

View reviewed changes

modules/subchannel/src/problems/SubChannel1PhaseProblem.C Show resolved Hide resolved

kyriv1980 force-pushed the delete_full_monlithic branch from 2c9bea4 to 7b09a19 Compare October 24, 2025 21:45

moosebuild added the PR: Failed but allowed label Oct 25, 2025

GiudGiud requested changes Oct 25, 2025

View reviewed changes

GiudGiud self-assigned this Oct 27, 2025

moosebuild removed the PR: Failed but allowed label Oct 27, 2025

kyriv1980 force-pushed the delete_full_monlithic branch 2 times, most recently from 00c2f09 to 1c7b477 Compare October 27, 2025 17:07

kyriv1980 requested a review from GiudGiud October 27, 2025 19:11

moosebuild added the PR: Failed but allowed label Oct 27, 2025

GiudGiud requested changes Oct 28, 2025

View reviewed changes

kyriv1980 force-pushed the delete_full_monlithic branch from 1c7b477 to 227290b Compare October 28, 2025 17:19

moosebuild removed the PR: Failed but allowed label Oct 28, 2025

kyriv1980 force-pushed the delete_full_monlithic branch 4 times, most recently from d1e1fca to a49a2ac Compare October 28, 2025 22:47

GiudGiud reviewed Oct 29, 2025

View reviewed changes

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md Outdated Show resolved Hide resolved

GiudGiud reviewed Oct 29, 2025

View reviewed changes

kyriv1980 force-pushed the delete_full_monlithic branch from a49a2ac to df34e81 Compare October 29, 2025 15:38

kyriv1980 requested a review from GiudGiud October 29, 2025 21:13

GiudGiud reviewed Oct 30, 2025

View reviewed changes

kyriv1980 force-pushed the delete_full_monlithic branch from df34e81 to f15c50f Compare October 30, 2025 15:46

kyriv1980 force-pushed the delete_full_monlithic branch 2 times, most recently from 6e2eabb to ba4f3cf Compare October 30, 2025 17:34

GiudGiud reviewed Oct 30, 2025

View reviewed changes

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md Outdated Show resolved Hide resolved

GiudGiud reviewed Oct 30, 2025

View reviewed changes

modules/subchannel/doc/content/modules/subchannel/general/subchannel_theory.md Outdated Show resolved Hide resolved

kyriv1980 force-pushed the delete_full_monlithic branch from ba4f3cf to 5e366b0 Compare October 30, 2025 18:58

kyriv1980 requested a review from GiudGiud November 6, 2025 16:16

kyriv1980 added a commit to kyriv1980/moose that referenced this pull request Nov 7, 2025

populate SumWij at the inlet (for viualization) Refs idaholab#31785

d06e97b

moosebuild added the PR: Failed but allowed label Nov 7, 2025

tanoret approved these changes Nov 7, 2025

View reviewed changes

kyriv1980 added 8 commits November 7, 2025 17:52

delete full monolithic solve idaholab#31044

1693311

document relaxation scheme idaholab#30037

784ed61

fix index in crossflow population and regold idaholab#31275

172966c

apply verbose lambda function idaholab#31044

ed9b0d0

improve readability idaholab#31044

bdeec41

remove monolithic flag from tests idaholab#31044

22bcaa6

address reviewer comments idaholab#31044

9df666e

populate SumWij at the inlet (for viualization) Refs idaholab#31785

ce6ccf5

kyriv1980 force-pushed the delete_full_monlithic branch from d06e97b to ce6ccf5 Compare November 8, 2025 00:52

moosebuild removed the PR: Failed but allowed label Nov 8, 2025

GiudGiud approved these changes Nov 8, 2025

View reviewed changes

GiudGiud changed the title ~~Delete full monolithic solver~~ Delete full monolithic solver & re-organize problems using lambdas Nov 8, 2025

GiudGiud merged commit ee1c546 into idaholab:next Nov 8, 2025
68 of 69 checks passed

kyriv1980 deleted the delete_full_monlithic branch November 10, 2025 18:06

Delete full monolithic solver & re-organize problems using lambdas #31785

Delete full monolithic solver & re-organize problems using lambdas #31785

Conversation

kyriv1980 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

moosebuild commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Framework coverage

Modules coverage

Subchannel

Full coverage reports

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Oct 29, 2025

Uh oh!

GiudGiud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Oct 30, 2025

Uh oh!

moosebuild commented Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Nov 7, 2025

Uh oh!

tanoret left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Nov 8, 2025

Framework test summary

Removed tests

Added tests

Run time changes

Modules test summary

Removed tests

Added tests

kyriv1980 commented Oct 24, 2025 •

edited

Loading

moosebuild commented Oct 25, 2025 •

edited

Loading

moosebuild commented Oct 25, 2025 •

edited

Loading