Skip to content

MFEM Non-linear support #31776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 50 commits into
base: next
Choose a base branch
from
Draft

MFEM Non-linear support #31776

wants to merge 50 commits into from
+3,246 −42

Conversation

@karthichockalingam
Copy link
Contributor

@karthichockalingam karthichockalingam commented Oct 23, 2025

The PR closes #31772

Thanks,
@alexanderianblair
@SohailSTFC
@nmnobre
Karthik.

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from f85429d to 827832a Compare October 23, 2025 19:10
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 827832a to 02e75a0 Compare October 23, 2025 19:43
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 02e75a0 to 1a1e2e6 Compare October 23, 2025 20:15
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 1a1e2e6 to 4a57b73 Compare October 23, 2025 21:00
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@moosebuild
Copy link
Contributor

moosebuild commented Oct 23, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on 62752f9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@karthichockalingam @nmnobre
Declare block vectors and arrays in header
27d814c
@karthichockalingam @nmnobre
Pass grid function and block offset to BuildEquationSystem
96c4e74
@karthichockalingam @nmnobre
apply essential bcs at dofs
4ffa664
@karthichockalingam @nmnobre
copy vector to blockvector
ef58038
@karthichockalingam @nmnobre
apply essential bc in mult
b853c2d
@karthichockalingam @nmnobre
Replace copy vec with dynamic cast to block vector
b6e2d9e
@karthichockalingam @nmnobre
Raplace applyDirchValues with ApplyEssVals
8fc6637
@karthichockalingam @nmnobre
Update jacobian in Mult
203b514
@karthichockalingam @nmnobre
Update time derivative essential constraints
2d9402e
@karthichockalingam @nmnobre
Call update time derivative essential bc in TimeDomainEquationSystemP…
3c9302f 
…roblemOperator
@karthichockalingam @nmnobre
Add Newton Mult to TimeDependentEquationSystem
78e1878
@karthichockalingam @nmnobre
replace bc_x with _dvardt_ess_constraints
634ba67
@karthichockalingam @nmnobre
Move ApplyEssentialBCs from BuildLinearFroms to EquationSystemProblem…
2c822c4 
…Operator::Solve()
@karthichockalingam @nmnobre
Using _var_ess_constraints for transient problems
1b03da4
@karthichockalingam @nmnobre
Made UpdateEssDerivativeVals member function of TimeDependentEquation…
05f730a 
…System
@karthichockalingam @nmnobre
Having one mult for EquationSystem and TimeDependentEquationSystem
ff10dec
@karthichockalingam @nmnobre
loop over _trial_var_names to populate _test_pfespaces
20bb916
@karthichockalingam @nmnobre
Add DomainLFGradKernel
f458dc6
@karthichockalingam @nmnobre
Add MFEMGradientGridFunction
3212858
@karthichockalingam @nmnobre
Use zero_vec instead of _true_rhs in problem operator
3249082
karthichockalingam and others added 17 commits October 27, 2025 12:32
@karthichockalingam @nmnobre
(1) Added aux vector for b contribution (2) Dropped bilinear contribu…
dd93bcd 
…tion from MFEMDomainLFGradKernel (3) Changed input file to have only source term with homogenouse bcs for a linear problem
@karthichockalingam @nmnobre
Add MixedScalarWeakDivergenceKernel
229bb0c
@karthichockalingam @nmnobre
Add input file for non-linear problem but not working
dd242f2
@karthichockalingam @nmnobre
Fix the sign on b
4de2d80
@karthichockalingam @nmnobre
Bug fix: Changed to use sol instead of _trueBlockSol in _jacobian->Ad…
7862ba7 
…dMult
@karthichockalingam @nmnobre
Dropped ApplyEssVals
22e3efa
@karthichockalingam @nmnobre
Take initial condition as initial guess
2f7e9ce
@karthichockalingam @nmnobre
Add newton paramaters from executioner block
94c90ab
@karthichockalingam @nmnobre
Change to the inputfile and square.e from mesh
29d55ea
@karthichockalingam @nmnobre
remove nldiffusion.i
bfbe700
@karthichockalingam @nmnobre
Rename file from true_nldiffusion.i to nldiffusion.i
ac37cf1
@karthichockalingam @nmnobre
change output folder name
053d4a5
@karthichockalingam @nmnobre
Add test for non-linear diffusion
0907f71
@karthichockalingam @nmnobre
Fixed typo in MFEMDomainLFGradKernel
79f780d
@karthichockalingam @nmnobre
Add documentation to kernels and functions
e4c22e0
@karthichockalingam @nmnobre
Clang formatted idaholab#31772
63a4a27
@nmnobre
Patch mfem::HypreGMRES/PCG to reset preconditioning matrix
d882727
@nmnobre nmnobre force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 4a57b73 to d882727 Compare October 27, 2025 13:03
moosebuild
moosebuild reviewed Oct 27, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

moosebuild
moosebuild reviewed Oct 28, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 1280a9a to 37726d5 Compare October 28, 2025 11:05
moosebuild
moosebuild reviewed Oct 28, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 37726d5 to a0e4ae3 Compare October 28, 2025 11:47
@moosebuild
Copy link
Contributor

moosebuild commented Oct 28, 2025

Job Precheck, step Clang format on 6588ac0 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31776/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2acb415a170285fef37748f90025af38c3977b3c

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 6588ac0 to 62752f9 Compare October 28, 2025 19:30
@moosebuild
Copy link
Contributor

moosebuild commented Oct 28, 2025

Job Test, step Results summary on 62752f9 wanted to post the following:

Framework test summary

Compared against 2acb415 in job civet.inl.gov/job/3334968.

Removed tests

Added tests

Test Time (s)
mfem/kernels.MFEMNonLinearDiffusion 8.24

Run time changes

Test Base (s) Head (s) +/-
mfem/kernels.MFEMCurlCurlLOR 10.22 17.00 +66.31%
mfem/kernels.MFEMGradDivLOR 6.41 9.88 +54.16%
mfem/kernels.MFEMDiffusionLOR 2.13 3.21 +50.79%

Modules test summary

Compared against 2acb415 in job civet.inl.gov/job/3334968.

Removed tests

Added tests

Run time changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moosebuild moosebuild moosebuild left review comments

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad will be requested when the pull request is marked ready for review lindsayad is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lindsayad lindsayad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MFEM Non-linear Solve

4 participants

@karthichockalingam @moosebuild @lindsayad @nmnobre