XYZDelaunay Hole Conversion and Stitching Improvements #31761
Conversation
miaoyinb
force-pushed
the
transitionXYZD
branch
2 times, most recently
from
82199b6 to
a082057
Compare
|
Job Documentation, step Docs: sync website on b7bd6c7 wanted to post the following: View the site here This comment will be updated on new commits. |
miaoyinb
force-pushed
the
transitionXYZD
branch
3 times, most recently
from
c16dc84 to
abe61df
Compare
|
Job Coverage, step Generate coverage on b7bd6c7 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
miaoyinb
force-pushed
the
transitionXYZD
branch
from
abe61df to
2ad7274
Compare
miaoyinb
force-pushed
the
transitionXYZD
branch
from
2ad7274 to
622dad1
Compare
miaoyinb
requested review from
GiudGiud,
lindsayad and
roystgnr
as code owners
| issues = '#31293' | ||
| issues = '#31293 #31759' | ||
| [simple_hex8] | ||
| type = Exodiff |
There was a problem hiding this comment.
what s the motivation for this?
now that the exodus files have been checked in (and their memory cost paid) it s as good a test as it can be for comparing meshes
There was a problem hiding this comment.
The conversion of QUAD4 faces to TRI3 faces relies on global node ids. Distributed mesh mode gives inconsistent node indexing and thus inconsistent division of QUAD4 faces.
There was a problem hiding this comment.
even with allow-renumbering = false?
There was a problem hiding this comment.
right, the GMG creates different node ids.
There was a problem hiding this comment.
maybe we should fix this.
is this PR awaited for analysis?
There was a problem hiding this comment.
No, it is not awaited.
There was a problem hiding this comment.
@roystgnr how big of a lift is it?
There was a problem hiding this comment.
This is mostly @miaoyinb's code in MooseMeshElementConversionUtils, isn't it? libMesh all_tri() uses geometry to determine which diagonal to turn into an edge, mostly to get higher quality elements, but also to get an output independent of numbering. But that would also need refactoring (to work on ranges of elements rather than whole meshes) to use here; it's not a drop-in replacement either. It would have been easier to refactor and extend originally than to attempt to rewrite, but only hindsight is 20/20, and IMHO it would now be a real delay to fix it either way.
There was a problem hiding this comment.
ok seems we have a path forward, which is to extend libMesh to allow a range of elements on that routine.
I think in the meantime we should revert the test changes, and set mesh_mode = replicated
Co-authored-by: Guillaume Giudicelli <[email protected]>
|
Job Test, step Results summary on b7bd6c7 wanted to post the following: Framework test summaryCompared against 2acb415 in job civet.inl.gov/job/3334968. Removed tests
Added tests
Run time changesModules test summaryCompared against 2acb415 in job civet.inl.gov/job/3334968. Removed testsAdded testsRun time changes |
4 participants
closes #31759