Add some caching to the solution UO #31748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Job Documentation, step Docs: sync website on 682484f wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Job Coverage, step Generate coverage on 682484f wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
lindsayad
requested changes
Oct 22, 2025
Comment on lines
1087
to
1088
| // if (p == _cached_p2 && (!subdomain_ids || (*subdomain_ids == _cached_subdomain_ids2))) | ||
| // return _cached_values2(local_var_index); |
Member
There was a problem hiding this comment.
If we're not going to use them, let's remove all the *2 variables
Contributor
Author
There was a problem hiding this comment.
ah yeah no this is accidental
| exodiff = "read_exodus_multiple_vars_out.e" | ||
| prereq = "write_exodus_multiple_vars" | ||
| issues = "#31238 #31747 #31767" | ||
| requirement = "The system shall be able to read in multiple variables from a previous exodus file, leveraging caching and time step interpolation." |
Member
There was a problem hiding this comment.
I'd make this requirement more specific to the solution user object. Basic exodus restart can read multiple variables
- uncomment my code - make requirement more precise
Contributor
|
Job Test, step Results summary on 682484f wanted to post the following: Framework test summaryRemoved testsNone Added tests
Run time changes
Modules test summaryRemoved testsNone Added testsNone Run time changesNone |
lindsayad
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31767
closes #31747