Skip to content

XFEM near-tip enrichment for crack propagation #31730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: next
Choose a base branch
from
Open

XFEM near-tip enrichment for crack propagation #31730

wants to merge 15 commits into from

Conversation

@donggiang
Copy link
Contributor

@donggiang donggiang commented Oct 15, 2025 •
edited
Loading

refs #31729

Reason

New features allow crack tip to be placed anywhere inside elements whose solutions are enriched. Consequently, it allows correct computation of stress and contour integrals such as J and C(t).

Design

Extended XFEM Repetition Logic in FEProblemBase
A new flag has been added to the FEProblemBase class, complementing the existing mechanism that detects changes in the background mesh. This enhancement ensures that XFEM solutions are repeated not only when the background mesh changes, but also when the cutter mesh advances by an arbitrary increment. Additionally, this resolves a visualization lag present in the previous implementation.

New Material Class: ComputeCrackTipEnrichmentIncrementalStrain
Introduces a new material class designed to enrich the solution field around crack tips while supporting nonlinear material behavior.

Impact

Improve the robustness and accuracy of the XFEM module

@donggiang donggiang changed the title XFEM near-tip enrichment for crack propagation #31729 XFEM near-tip enrichment for crack propagation Oct 15, 2025
@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch from 929d4d2 to 0f919c1 Compare October 16, 2025 15:54
lindsayad
lindsayad reviewed Oct 16, 2025
View reviewed changes
@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch 4 times, most recently from 212475f to 8793ed1 Compare October 21, 2025 14:40
@moosebuild
Copy link
Contributor

moosebuild commented Oct 21, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on e8b7111 wanted to post the following:

View the site here

This comment will be updated on new commits.

@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch from 0b63754 to 0fe8570 Compare October 21, 2025 20:10
@moosebuild
Copy link
Contributor

moosebuild commented Oct 22, 2025 •
edited
Loading

Job Coverage, step Generate coverage on e8b7111 wanted to post the following:

Framework coverage

e0c998 #31730 e8b711
Total Total +/- New
Rate 85.98% 85.97% -0.00% 100.00%
Hits 124191 124191 - 7
Misses 20255 20261 +6 0

Diff coverage report

Full coverage report

Modules coverage

Fluid properties

e0c998 #31730 e8b711
Total Total +/- New
Rate 85.93% 85.92% -0.01% -
Hits 8188 8187 -1 0
Misses 1341 1342 +1 0

Diff coverage report

Full coverage report

Solid mechanics

e0c998 #31730 e8b711
Total Total +/- New
Rate 84.97% 84.96% -0.01% 100.00%
Hits 28104 28105 +1 12
Misses 4972 4975 +3 0

Diff coverage report

Full coverage report

Xfem

e0c998 #31730 e8b711
Total Total +/- New
Rate 82.62% 82.78% +0.16% 100.00%
Hits 7133 7245 +112 123
Misses 1500 1507 +7 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@bwspenc
Copy link
Contributor

bwspenc commented Oct 22, 2025

You'll need to reference an issue number. I would do it both in the title of your commit message (something like "ref #xxxxxx") as well as in the PR description, which you can edit.

@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch from 02ba5c6 to 3b3fa86 Compare October 22, 2025 15:30
bwspenc
bwspenc requested changes Oct 22, 2025
View reviewed changes
modules/xfem/src/materials/ComputeCrackTipEnrichmentIncrementalStrain.C Outdated
_phi(_assembly.phi()),
_grad_phi(_assembly.gradPhi()),
_mechanical_strain_old(getMaterialPropertyOld<RankTwoTensor>(_base_name + "mechanical_strain")),
_total_strain_old(getMaterialPropertyOld<RankTwoTensor>(_base_name + "total_strain")),
Copy link
Contributor

@bwspenc bwspenc Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have _total_strain_old defined in ComputeIncrementalStrainBase.

modules/xfem/test/tests/crack_tip_test/tests Outdated
[Tests]
issues = '#31729'
design = 'ComputeCrackTipEnrichmentIncrementalStrain.md'
requirement = 'The XFEM Module shall have the capability to allow crack tip'
Copy link
Contributor

@bwspenc bwspenc Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a separate requirement for each test, and those requirements should specifically state the capabilities tested.

Copy link
Contributor Author

@donggiang donggiang Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two seperate requirements for each test.

donggiang and others added 9 commits October 23, 2025 11:02
@donggiang @bwspenc
Apply suggestions from code review
c171e6c 
Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update framework/src/problems/FEProblemBase.C
78782a8 
Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/solid_mechanics/include/materials/ComputeIncrementalSt…
23841ad 
…rainBase.h

Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/solid_mechanics/include/userobjects/CrackFrontDefiniti…
af98e61 
…on.h

Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/solid_mechanics/src/userobjects/CrackFrontDefinition.C
7d2e10a 
Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/xfem/doc/content/source/materials/ComputeCrackTipEnric…
84a67e1 
…hmentIncrementalStrain.md

Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/xfem/include/base/XFEM.h
9c7b4bb 
Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/xfem/include/materials/ComputeCrackTipEnrichmentIncrem…
ec3ea75 
…entalStrain.h

Co-authored-by: Ben Spencer <[email protected]>
@donggiang @bwspenc
Update modules/xfem/src/materials/ComputeCrackTipEnrichmentIncrementa…
0b02ad9 
…lStrain.C

Co-authored-by: Ben Spencer <[email protected]>
@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch from 99b64b8 to 12d5e3b Compare October 28, 2025 16:27
@moosebuild
Copy link
Contributor

moosebuild commented Oct 28, 2025

Job Precheck, step Clang format on 12d5e3b wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31730/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2acb415a170285fef37748f90025af38c3977b3c

@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch 2 times, most recently from ebf2466 to 2ca2fc6 Compare October 29, 2025 15:42
@donggiang donggiang force-pushed the EnrichmentIncrementalStrain branch from 2ca2fc6 to e8b7111 Compare October 29, 2025 19:10
@moosebuild
Copy link
Contributor

moosebuild commented Oct 29, 2025

Job Test, step Results summary on e8b7111 wanted to post the following:

Framework test summary

Compared against e0c9988 in job civet.inl.gov/job/3341939.

Removed tests

Added tests

Run time changes

Test Base (s) Head (s) +/-
neml2/torchscript.heat_conduction 2.03 3.16 +55.98%

Modules test summary

Compared against e0c9988 in job civet.inl.gov/job/3341939.

Removed tests

Added tests

Test Time (s)
xfem/test:crack_tip_test.tip_location 2.85
xfem/test:crack_tip_test.JIntegral 2.80

Run time changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindsayad lindsayad lindsayad left review comments

@bwspenc bwspenc bwspenc requested changes

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84 jiangwen84 is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@bwspenc bwspenc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@donggiang @moosebuild @bwspenc @lindsayad