-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding moose-python conda package #31669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
76f592d to
419db7d
Compare
|
Job Precheck, step Versioner verify on 419db7d wanted to post the following: Versioner templatesFound 17 templates, 0 failed Versioner influential filesFound 69 influential files, 0 changed, 11 added, 0 removed
Versioner versionsFound 10 packages, 1 changed, 0 failed
|
|
Job Documentation, step Docs: sync website on 419db7d wanted to post the following: View the site here This comment will be updated on new commits. |
419db7d to
fe447df
Compare
| self.assertEqual(Versioner.match_date('xxx2025.04.04xxx'), (2025, 4, 4)) | ||
| self.assertEqual(Versioner.match_date('20.01.01'), None) | ||
|
|
||
| class TestVerify(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add docstrings for the tests that briefly describe what they're doing and how
| continue | ||
| change_text = 'BEHIND' if changes else colorize('OK', 'GREEN') | ||
| entries.append((package.name, change_text, to_path, template_path)) | ||
| entries.append([package.name, change_text, to_path, template_path]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why tuple to list?
| {% set version = "2025.10.02" %} | ||
|
|
||
| package: | ||
| name: moose-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might conflict with the internal name I already used in moose-python with the MPI package:
Line 109 in ee0740d
| - name: moose-python |
Refs #31668