Add JunctionComponent #31660
Open
Add JunctionComponent #31660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra ; in vector param Double register mesh generator type because it's needed Skip a check in test generator hacking the parameters of the stitcher
…eed to address issue with Seg Fault with attempting to get the direciton.
…r Cylinder component on prescribed point
…to conversion from XYZ extrinsic rotation to XZX intrinsic rotation (see TranformGenerator)
- Added new method for creating rotation matrix between two vectors. - Updated ComponentMeshTransformHelper to rotate correctly. - Added new capabilities for rotation in TransformGenerator using either extrinsic angles or a given rotation matrix. - Created simple test file for verifying everything works. closes idaholab#31157
…nt side mesh before extrusion.
…tion of primitive boundary layers. Created tests and updated gold files.
…ontrol points and an interpolating polynomial degree and returns a BSpline object, which can be evaluated for values of t on the standard interval [0,1]. Test cases were created to verify degree-varying capabilities and user feedback when the number of control points is insufficient. closes idaholab#30820
…notVector method.
…ents in source and header file
Created additional utility and tests to create ideal control points for the submitted BSpline utility. Control points are create such that the supplied derivatives at each point are honored. User will be able to control the placement of the points and the densitity of these points. closes idaholab#30928
… on ParsedCurveGenerator
…x issue with final test not passing.
…ators to JunctionComponent. Create JunctionComponent test. Move new component to dev directory for faster compiling.
…view output. Future work needed to create tests.
…l_gap and stitch_meshes options. To Do: - fix CombineComponentsMeshes.C to only combine where meshes are discontinuous (not stitched) - check that stitching for stitch_meshes is done properly (or returns an error if not)
…for now until flexibility is added.
… stitching. Update JunctionComponent to always be picky.
IDs in stitched mesh were being combined when max base mesh BID was lower than stitched_mesh max boundary ID.
…being calculated with the wrong vectors.
…truderGenerator. Create test for this in CylinderComponent for 2D case. Move COM finder for meshes to separate utility and update BSplineCurveGenerator to reflect this (along with AdvancedExtruderGenerator).
- continue expansion work on CAC - set dimension properly in JunctionComponent
…lapping elements.
…tch target mesh by forcing closure - Add intended start radius as parameter to AEG to conserve surface area - Add necessary parameters to Cylinder and Junction components
…special case of (-1,0,0). Additional work needed to rotate 180 degrees for arbitrary input vector.
- Add edge node names to BSplineCurve - Add edge node names to JunctionComponent Currently not working...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #31659 #31130
Reason
Creates a new ActionComponent that allows user to create connections between other ActionComponents. This allows for expanded capabilities in mesh creation and simulation design.
Design
JunctionComponent
Impact
Adds to existing ActionComponents