Add two MFEM auxkernels for L2-averaged inner and cross product of two source (par)gridfucntions projected onto an MFEM AuxVariable #31613

Giannis95 · 2025-09-26T07:51:04Z

framework/include/mfem/auxkernels/MFEMCrossProductAux.h

GiudGiud · 2025-10-13T14:07:28Z

@Giannis95 we prefer rebasing (over devel usually, only over next if something you need is not in devel yet) over merge commits btw

moosebuild · 2025-10-22T10:26:00Z

Job Precheck, step Size check on 0e6176e wanted to post the following:

Warning: This PR changes repo size by 102.59 MiB.

moosebuild · 2025-10-22T13:06:57Z

Job Documentation, step Docs: sync website on c7d5559 wanted to post the following:

View the site here

This comment will be updated on new commits.

…jection on a vector MFEM aux variable.

Co-authored-by: Guillaume Giudicelli <[email protected]>

…,documentation and checks changes. Refs #idaholab#31612

…ang-format. Refs idaholab#31612

GiudGiud

early review, nothing major

framework/doc/content/source/mfem/auxkernels/MFEMCrossProductAux.md

framework/doc/content/source/mfem/auxkernels/MFEMDotProductAux.md

framework/include/mfem/auxkernels/MFEMCrossProductAux.h

framework/src/mfem/fespaces/MFEMScalarFESpace.C

framework/src/mfem/fespaces/MFEMVectorFESpace.C

test/tests/mfem/auxkernels/tests

Co-authored-by: Guillaume Giudicelli <[email protected]>

…ing block close in test, remove repetative warning. Refs idaholab#31612

…2 vectors and fix the auxkernel test cli_args. Refs idaholab#31612

…lab#31612

GiudGiud · 2025-10-30T18:31:39Z

Seems one of the tests is really long btw. We should aim for <2s

please ping me when you want a review

… Refs idaholab#31612

…daholab#31612

…olab#31612

…d second_source_vec. Refs idaholab#31612

Giannis95 · 2025-11-03T14:53:55Z

Seems one of the tests is really long btw. We should aim for <2s

please ping me when you want a review

Hi, your previous comments are addressed, and this PR is now updated and ready for review. Thank you

…ce which will inncrease the test time (for the parallel test).Refs idaholab#31612

GiudGiud

ready of that

I think you are missing a test for the postprocessor?

framework/include/mfem/auxkernels/MFEMCrossProductAux.h

framework/src/mfem/auxkernels/MFEMCrossProductAux.C

framework/src/mfem/auxkernels/MFEMDotProductAux.C

framework/src/mfem/postprocessors/MFEMVectorL2InnerProductIntegralPostprocessor.C

Co-authored-by: Guillaume Giudicelli <[email protected]>

moosebuild · 2025-11-06T14:23:08Z

Job Precheck, step Clang format on 43e62dc wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31613/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 7323e92e13d5c77e1d5af55f58c42cce19c9d9f4

Giannis95 · 2025-11-06T16:19:29Z

ready of that

I think you are missing a test for the postprocessor?

I developed that postprocessor for the previous CSVdiff for the CrossProduct test, which had a runtime of >6s. Since we are now using a simpler test that does not need that postprocessor, it has been decided not to include it in this PR and to create another one at a later date, which will also update the terminology from _primal_var and dual_var to first and second in the other postprocessors too.

…typo and clang-format. Refs idaholab#31612

moosebuild · 2025-11-06T18:06:26Z

Job Test, step Results summary on c7d5559 wanted to post the following:

Framework test summary

Compared against 7323e92 in job civet.inl.gov/job/3361666.

Removed tests

Added tests

Test	Time (s)
`mfem/auxkernels.MFEMDotProductAux.C`	0.92
`mfem/auxkernels.MFEMCrossProductAux.C`	0.78

Run time changes

Modules test summary

Compared against 7323e92 in job civet.inl.gov/job/3361666.

Removed tests

Added tests

Run time changes

moosebuild · 2025-11-06T21:19:49Z

Job Coverage, step Generate coverage on c7d5559 wanted to post the following:

Framework coverage

	7323e9	#31613 c7d555
	Total	Total	+/-	New
Rate	86.02%	86.02%	+0.00%	100.00%
Hits	124629	124696	+67	78
Misses	20254	20264	+10	0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

GiudGiud · 2025-11-06T23:54:47Z

looks good

GiudGiud reviewed Sep 28, 2025

View reviewed changes

framework/include/mfem/auxkernels/MFEMCrossProductAux.h Show resolved Hide resolved

Giannis95 pushed a commit to Giannis95/moose that referenced this pull request Oct 13, 2025

Rebased and conflict resolved L2Int addition. Refs idaholab#31613

e5ed57d

GiudGiud self-assigned this Oct 15, 2025

Giannis95 marked this pull request as ready for review October 22, 2025 09:40

Giannis95 requested a review from lindsayad as a code owner October 22, 2025 09:40

Ioannis-UKAEA and others added 10 commits October 24, 2025 13:35

Initial commit for the inner product aux kernel .C and .h

fcc5c55

Initiall structure for the Cross Product AuxKernel s(x) * (U x V) pro…

5953d06

…jection on a vector MFEM aux variable.

Update framework/include/mfem/auxkernels/MFEMCrossProductAux.h

9516ee2

Co-authored-by: Guillaume Giudicelli <[email protected]>

Add the L2 fe space with map_type = INTEGRAL. refs idaholab#31612

5ccf432

Rebased and conflict resolved L2Int addition. Refs idaholab#31613

d23ae7c

Add documentation and tests for the InnerProduct. Refs idaholab#31612

39387c2

Add L2 option for MFEMVectorFESpaces and cross-product auxkernel test…

de7338c

…,documentation and checks changes. Refs #idaholab#31612

Fix EOF. Refs idaholab#31612

d046ff2

Remove unicode characters. Refs idaholab#31612

d27bc9c

change test from XMLDiff to csvdiff due to large data files, fixed cl…

b5e1d6d

…ang-format. Refs idaholab#31612

Giannis95 force-pushed the Giannis95/MFEMInnerCrossProductAux branch from b141f31 to b5e1d6d Compare October 24, 2025 12:51

GiudGiud reviewed Oct 25, 2025

View reviewed changes

Giannis95 and others added 8 commits October 27, 2025 13:39

Apply suggestions from code review

79cb0de

Co-authored-by: Guillaume Giudicelli <[email protected]>

Move the cross product auxkernel checks before construction, add miss…

94d0626

…ing block close in test, remove repetative warning. Refs idaholab#31612

clang-format. Refs idaholab#31612

9c611d5

Fix auxkernels test file. Refs idaholab#31612

d6c6f5f

Add a new MFEMVectorL2InnerProductIntegralPostprocessor which allow L…

ca2b748

…2 vectors and fix the auxkernel test cli_args. Refs idaholab#31612

Typos fix. Refs idaholab#31612

5439ac6

Clean up dot product auxkernel. Refs idaholab#31612

757e748

delete whitespaces. Refs idaholab#31612

2e3fcde

Giannis95 added 5 commits October 30, 2025 15:18

deactive joule_Q_aux block. Refs idaholab#31612

c41ff3a

Fix input file type. Refs idaholab#13612

de1f3be

av_magnetostatic block change. Refs idaholab#31612

fba3115

Update the execution orders in the cross_product examples. Refs idaho…

b74dd79

…lab#31612

update the inner product test. Refs idaholab#31612

1a948f2

Giannis95 and others added 9 commits October 31, 2025 11:09

Test moving everything in the constructor for the cross-product test.…

c0eb0de

… Refs idaholab#31612

Simplified cross product test with runtime less than a second. Refs i…

2f8091d

…daholab#31612

Whitespaces fix. Refs idaholab#31612

947c539

Clean up av_magnetostatic. Refs idaholab#31612

c9b17f9

Test fix. Refs idaholab#31612

d71b22d

Restructure InnerProduct auxkernel. Refs idaholab#31612.

9e55ffd

apply patch. Refs idaholab#31612

252de90

Tighten up the solver tolerance for the inner product test. Refs idah…

59617c1

…olab#31612

Rename input vector variable names for clarity to first_source_vec an…

cb8343d

…d second_source_vec. Refs idaholab#31612

Giannis95 requested a review from GiudGiud November 3, 2025 15:03

Add softer XLMDiff requiriments to avoid reducing the solvers toleran…

17ab87f

…ce which will inncrease the test time (for the parallel test).Refs idaholab#31612

GiudGiud reviewed Nov 3, 2025

View reviewed changes

Apply suggestions from code review

43e62dc

Co-authored-by: Guillaume Giudicelli <[email protected]>

Adding missing docstrings, delete postprocessor, fix auxkernels/test …

c7d5559

…typo and clang-format. Refs idaholab#31612

GiudGiud approved these changes Nov 6, 2025

View reviewed changes

GiudGiud merged commit 75e4c83 into idaholab:next Nov 6, 2025
68 of 69 checks passed

Add two MFEM auxkernels for L2-averaged inner and cross product of two source (par)gridfucntions projected onto an MFEM AuxVariable #31613

Add two MFEM auxkernels for L2-averaged inner and cross product of two source (par)gridfucntions projected onto an MFEM AuxVariable #31613

Conversation

Giannis95 commented Sep 26, 2025

Uh oh!

Uh oh!

GiudGiud commented Oct 13, 2025

Uh oh!

moosebuild commented Oct 22, 2025

Uh oh!

moosebuild commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GiudGiud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GiudGiud commented Oct 30, 2025

Uh oh!

Giannis95 commented Nov 3, 2025

Uh oh!

GiudGiud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moosebuild commented Nov 6, 2025

Uh oh!

Giannis95 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moosebuild commented Nov 6, 2025

Framework test summary

Removed tests

Added tests

Run time changes

Modules test summary

Removed tests

Added tests

Run time changes

Uh oh!

moosebuild commented Nov 6, 2025

Framework coverage

Modules coverage

Full coverage reports

Uh oh!

GiudGiud commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

moosebuild commented Oct 22, 2025 •

edited

Loading

Giannis95 commented Nov 6, 2025 •

edited

Loading