Making suricata run in socket mode for pcap processing improvement #617
+360
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing cisagov#457
We can address whether we need 33-suricata-socket.yml. We can just merge that into 11-suricata.yml if we never intend to use the other way moving forward. Otherwise I implemented the socket logic in a new class and included that in pcap_processor.py.
I then tested by spinning up a docker image with the pcap_watcher and moving PCAPs into the correct directory. For each PCAP placed in the input folder I was able to see a directory be made with an eve.json within filled with suricata data. See attached screenshot.