Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit/delete reviews, refactor review components #487

Merged
merged 38 commits into from
Oct 16, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Oct 10, 2024

Description

  • Add edit and delete buttons to reviews you've written
  • Updated author icon to match style of verified icon
  • refactored review, subreview, reviewform, userreviews components
  • link reviews on reviews page to respective course/professor

Screenshots

image
image
image

Steps to verify/test this change:

  • Edit and delete buttons appear on authored reviews on the user reviews page and course/professor pages
  • Edit review form shows correct course and/or professor in title
  • Current values of the review form should be preloaded
  • Form validation should be reset if a user edits the same review twice in a row (should not see any green outlines or checkmarks when editing the second time)
  • Should NOT be able to change course or professor when editing from user reviews page
  • Should be able to change professor but not course when editing from course page
  • Should be able to change course but not professor when editing from professor page
  • Changes (edit or delete) should reflect immediately
  • Changes (edit or delete) should persist after reloading the page
  • Adding a review for a professor still functions as normal
  • Adding a review for a course still functions as normal

Next steps

  • Use professor name not ucinetid for reviews and edit review form on user page
    • include space between course department & number too for consistency

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #273, closes #428

SenghoungLim and others added 27 commits January 23, 2024 10:02
@js0mmer js0mmer self-assigned this Oct 10, 2024
@js0mmer js0mmer temporarily deployed to staging-487 October 10, 2024 06:08 — with GitHub Actions Inactive
@js0mmer js0mmer mentioned this pull request Oct 10, 2024
4 tasks
@js0mmer js0mmer temporarily deployed to staging-487 October 10, 2024 06:39 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-487 October 11, 2024 00:29 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-487 October 11, 2024 01:54 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-487 October 11, 2024 02:07 — with GitHub Actions Inactive
@js0mmer js0mmer marked this pull request as ready for review October 11, 2024 02:09
@js0mmer js0mmer changed the title Add ability to edit/delete reviews Add ability to edit/delete reviews, refactor review components Oct 11, 2024
api/src/controllers/reviews.ts Outdated Show resolved Hide resolved
site/src/pages/ReviewsPage/ReviewsPage.scss Outdated Show resolved Hide resolved
site/src/store/slices/reviewSlice.ts Outdated Show resolved Hide resolved
@js0mmer js0mmer temporarily deployed to staging-487 October 16, 2024 19:48 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit cc7cd3e into master Oct 16, 2024
2 checks passed
@js0mmer js0mmer deleted the edit-reviews branch October 16, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants