Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use backend without mongo url env secret #478

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Conversation

ptruong0
Copy link
Contributor

@ptruong0 ptruong0 commented May 20, 2024

Description

Check for mongo env variable in app.ts. Also added some error handling on the backend to handle failed requests to roadmap, reviews, etc routes

Search, course, and professor pages should work as usual. Roadmaps can be saved locally but not to the user account.

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #446

@ptruong0 ptruong0 temporarily deployed to staging-478 May 20, 2024 04:50 — with GitHub Actions Inactive
@ptruong0 ptruong0 requested a review from js0mmer May 22, 2024 19:05
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting these errors when running locally with the example env file. Doesn't seem related to Mongo but it still prevents users from running without secrets.

image

I've suggested some conditions that should fix this

api/src/app.ts Outdated Show resolved Hide resolved
@ptruong0 ptruong0 temporarily deployed to staging-478 June 9, 2024 01:42 — with GitHub Actions Inactive
@ptruong0 ptruong0 temporarily deployed to staging-478 June 9, 2024 02:01 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-478 September 23, 2024 17:09 — with GitHub Actions Inactive
@js0mmer js0mmer self-requested a review September 23, 2024 17:21
@js0mmer js0mmer merged commit 57b0f3f into master Sep 23, 2024
2 checks passed
@js0mmer js0mmer deleted the phil/no-mongo branch September 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use backend without mongo url env secret
2 participants