Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the quarters offered tooltip more useful #462

Merged
merged 6 commits into from
Mar 9, 2024

Conversation

ptruong0
Copy link
Contributor

@ptruong0 ptruong0 commented Mar 7, 2024

Description

Changed the colored dots to emojis that represent the quarter, and used the previous academic year (e.g. fall 2022 & winter/spring/summer 2023) instead of 2020. Inside the tooltip on hover, added a chart that shows the frequencies of each term in the past. Also added the tooltips to the course page and the course cards on the roadmap page.

Screenshots

image

Tooltip on hover

image

Not offered in the previous year

image

No recent term data

image

Course page

image

Roadmap page

image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #295

@ptruong0 ptruong0 temporarily deployed to staging-462 March 7, 2024 08:21 — with GitHub Actions Inactive
@ptruong0 ptruong0 self-assigned this Mar 7, 2024
@ptruong0 ptruong0 requested a review from js0mmer March 7, 2024 08:28
@ptruong0 ptruong0 temporarily deployed to staging-462 March 7, 2024 08:30 — with GitHub Actions Inactive
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excited for this feature. I want to wait for the api team to fix the terms list before we merge though.

Note: I see that the chart is mostly copy/pasted from the gradedist. This is fine for now. In the future, we probably want to refactor to eliminate redundancy (and switch from class component to functional).

site/src/component/QuarterTooltip/Chart.tsx Outdated Show resolved Hide resolved
@js0mmer js0mmer self-requested a review March 8, 2024 06:53
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're good to go.

@ptruong0 ptruong0 changed the title Phil/quarter tooltips Make the quarters offered tooltip more useful Mar 8, 2024
@ptruong0 ptruong0 temporarily deployed to staging-462 March 8, 2024 22:43 — with GitHub Actions Inactive
@ptruong0
Copy link
Contributor Author

ptruong0 commented Mar 8, 2024

LGTM! Excited for this feature. I want to wait for the api team to fix the terms list before we merge though.

Note: I see that the chart is mostly copy/pasted from the gradedist. This is fine for now. In the future, we probably want to refactor to eliminate redundancy (and switch from class component to functional).

Yeah, I was wondering why that component in particular was a class component. I just copied over the component instead of reusing because there were a lot of small chart settings that I changed

@ptruong0 ptruong0 temporarily deployed to staging-462 March 8, 2024 22:45 — with GitHub Actions Inactive
@ptruong0 ptruong0 merged commit 5032f17 into master Mar 9, 2024
3 checks passed
@ptruong0 ptruong0 deleted the phil/quarter-tooltips branch March 9, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the quarters offered tooltip more useful
2 participants