-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the quarters offered tooltip more useful #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excited for this feature. I want to wait for the api team to fix the terms list before we merge though.
Note: I see that the chart is mostly copy/pasted from the gradedist. This is fine for now. In the future, we probably want to refactor to eliminate redundancy (and switch from class component to functional).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're good to go.
Co-authored-by: Jacob Sommer <[email protected]>
Yeah, I was wondering why that component in particular was a class component. I just copied over the component instead of reusing because there were a lot of small chart settings that I changed |
Description
Changed the colored dots to emojis that represent the quarter, and used the previous academic year (e.g. fall 2022 & winter/spring/summer 2023) instead of 2020. Inside the tooltip on hover, added a chart that shows the frequencies of each term in the past. Also added the tooltips to the course page and the course cards on the roadmap page.
Screenshots
Tooltip on hover
Not offered in the previous year
No recent term data
Course page
Roadmap page
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #295