-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog Modal #440
Changelog Modal #440
Conversation
The content can be changed later, does the UI look okay? |
Same thing as I said here for the most part: #426 (comment) I think it should be consistent with #419's modal with the background color, no borders, and large X button. I believe I also used a filled background with white text for the button, though that was more of a call to action than this one. Layout other than that looks fine to me. |
Do you think the close button is still necessary? Right now, there are 3 ways to close the modal: (1) X button, (2) Close button at the bottom, (3) Clicking outside the modal. |
I'd say it's unnecessary. |
Co-authored-by: Jacob Sommer <[email protected]>
Co-authored-by: Jacob Sommer <[email protected]>
Co-authored-by: Jacob Sommer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think for now we can just comment out the ChangelogModal within the App component. Once we add something new, someone can uncomment it and write up a changelog.
The padding of this modal looks different from the padding of the year modal, but I think this is not as big of a deal right now (I should make a PR later to use those styles for all modal elements instead of asking each PR author to copy code to make theirs consistent) However, I do think you should make the modal enter/exit smoothly like the add year one instead of just disappearing instantly when the close button is clicked |
Description
Created a modal element that contains a text description and image. Should only appear once since I set a variable in local storage that prevents the modal from being shown the next time the website is loaded.
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #