-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisite unmet popup in search results #458
base: master
Are you sure you want to change the base?
Conversation
I think the icon itself is not very easy to tell what it means. Why not just make it consistent with what happens if you actually put it on the roadmap, that is, use the warning sign icon (at least for now)? |
I also think in that for the roadmap in general, the warning and info can probably be combined into one icon, though that affects more areas than you're addressing in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the warning icon should be moved to the bottom left so it is consistent with the roadmap. Additionally, top right would conflict with #462.
Why not reuse the existing warning popover/logic?
The current popover logic relies on finding invalid courses that are already in the roadmap by going through each course and creating an array of objects that have This will probably have to be refactored in a PR of a different scope because the current way the roadmap detects unmatched prerequisites isn't reusable to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My one concern though is that the logic for this is implemented in SearchHitContainer component which is also reused for the course/professor catalog pages. It doesn't seem to be cause any errors though.
Description
When searching for a course, an indicator may show up in the search bar if you haven't met prerequisites from your current roadmap.
Screenshots
Screen.Recording.2024-03-06.at.2.17.37.PM.mov
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #451