This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
feat: ✨ fuzzy SaaS #141
Open
feat: ✨ fuzzy SaaS #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
5 tasks
js0mmer
reviewed
May 1, 2024
There was a problem hiding this comment.
just from some quick tests, performance looks good but some results are unexpected. searching for "ics" seems to be a problem since the course names are actually I&C SCI, although I've managed to have a similar issue with art. I think some kind of weighting so the department name is more important than the course title could help with the results here.
see icssc/peterportal-client#466 (comment) and icssc/peterportal-client#466 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement fuzzy search as a service through REST and GraphQL (
searchCoursesandsearchInstructors, since GraphQL doesn't support tagged union/sum types).The total number of results is returned in the
countfield in the payload, and the result set (containing at most the requested number of results starting from the offset) is returned in theresultsfield.Parameters
query: The string to fuzzy-search. Required.resultType: The type of result to return exclusively,courseorinstructor. Both types of results will be returned if left undefined.limitandoffset: For pagination purposes, defaults to 10 and 0 respectively.Issues
Closes #131.