Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: ✨ refine course history scraper #135

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat: ✨ refine course history scraper #135

merged 2 commits into from
Mar 8, 2024

Conversation

cokwong
Copy link
Contributor

@cokwong cokwong commented Feb 29, 2024

Summary

  • Term history for courses were originally cross-referenced from scraped instructors' data. Some courses have instructors not in the directory or just Staff resulting in missing terms.

  • Implemented crawler to scrape course history of a department from EnrollHist.

  • The new data is joined with the original results from instructors' course history (in case crawler fails).

Issues

@cokwong cokwong linked an issue Feb 29, 2024 that may be closed by this pull request
@cokwong cokwong temporarily deployed to staging-135 February 29, 2024 02:56 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-135-docs February 29, 2024 02:56 — with GitHub Actions Inactive
@cokwong cokwong changed the title Refine course history scraper feat: ✨ refine course history scraper Feb 29, 2024
@cokwong cokwong changed the title feat: ✨ refine course history scraper feat: ✨ refine course history scraper Feb 29, 2024
@ecxyzzy ecxyzzy self-requested a review March 7, 2024 21:41
Copy link
Member

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

The instructors' course history isn't updated but to be fair the issue also didn't mention it. I'll create a new issue to track that.

@ecxyzzy ecxyzzy merged commit f7d9660 into main Mar 8, 2024
6 of 8 checks passed
@ecxyzzy ecxyzzy deleted the enroll-hist branch March 8, 2024 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrape course history from WebReg EnrollHist
2 participants