Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

chore: 🔧 clean up workspace, add utils [skip ci] #129

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Feb 6, 2024

Summary

  • Changed version specifiers for all internal packages to workspace:^.
  • Moved all workspace root devDependencies to full dependencies and removed production deployment shim. Also added ignore-workspace-root-check to the .npmrc so pnpm won't complain when trying to install a dependency in the workspace root.
    • I was going to add @manypkg/cli, but they change the version specifier for all packages (even internal) from workspace:^ to the actual version, which is not ideal for our usecase.
  • Moved sleep and notNull to a new package @libs/utils.
  • Added @typescript-eslint/consistent-type-imports, which enforces the import type syntax for type imports, to the eslintrc, and relinted the repo.
  • Added .then() to async entrypoints, and removed dummy then callbacks (e.g. (() => [])).

Issues

Closes #89; closes #90.

@ecxyzzy ecxyzzy added the no deploy Do not deploy this pull request to staging label Feb 6, 2024
@ecxyzzy ecxyzzy requested a review from ap0nia February 6, 2024 19:49
@github-actions github-actions bot changed the title chore: clean up workspace, add utils [skip ci] chore: 🔧 clean up workspace, add utils [skip ci] Feb 6, 2024
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too opinionated on devops atm, so I think it's fine to implement whatever changes you're interested in, and then open up a discussion later if that's desired. 👍

.eslintrc.cjs Show resolved Hide resolved
.npmrc Outdated Show resolved Hide resolved
libs/utils/package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@ecxyzzy ecxyzzy merged commit f8539de into main Feb 12, 2024
5 checks passed
@ecxyzzy ecxyzzy deleted the cleanup-and-utils branch February 12, 2024 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no deploy Do not deploy this pull request to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utils package Clean up workspace
2 participants