Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: ✨ add previews for courses/instructors #119

Merged
merged 8 commits into from
Jan 17, 2024
Merged

feat: ✨ add previews for courses/instructors #119

merged 8 commits into from
Jan 17, 2024

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Dec 28, 2023

TODO before merging: copy dev schema courses/instructors table to prod.

@ecxyzzy ecxyzzy temporarily deployed to staging-119 December 28, 2023 09:26 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119-docs December 28, 2023 09:26 — with GitHub Actions Inactive
@github-actions github-actions bot changed the title feat: add previews for courses/instructors (WIP) feat: ✨ add previews for courses/instructors (WIP) Dec 28, 2023
@ecxyzzy ecxyzzy temporarily deployed to staging-119 December 28, 2023 09:34 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119-docs December 28, 2023 09:34 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119 December 28, 2023 13:12 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119-docs December 28, 2023 13:12 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy changed the title feat: ✨ add previews for courses/instructors (WIP) feat: ✨ add previews for courses/instructors Dec 29, 2023
@ecxyzzy ecxyzzy marked this pull request as ready for review December 29, 2023 09:34
@ecxyzzy ecxyzzy requested a review from ap0nia December 29, 2023 09:34
ap0nia
ap0nia suggested changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 💪
I left mostly database design considerations lol. The code looks fine; once it's clear what how we'd like the database to be organized, I think it's good to merge.

apps/api/src/lib/utils.ts Outdated Show resolved Hide resolved
apps/api/src/lib/utils.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/graphql/schema/instructors.graphql Show resolved Hide resolved
libs/db/prisma/schema.prisma Show resolved Hide resolved
libs/db/prisma/schema.prisma Show resolved Hide resolved
libs/db/prisma/schema.prisma Show resolved Hide resolved
tools/registrar-scraper/src/instructor-scraper/index.ts Outdated Show resolved Hide resolved
tools/registrar-scraper/src/instructor-scraper/index.ts Outdated Show resolved Hide resolved
tools/registrar-scraper/src/index.ts Outdated Show resolved Hide resolved
tools/registrar-scraper/src/index.ts Outdated Show resolved Hide resolved
ecxyzzy
ecxyzzy commented Jan 10, 2024
View reviewed changes
Copy link
Member Author

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I've incorporated most of the suggestions.

For posterity, we discussed the schema issues in DMs. We may consider in the future to use actual SQL relations, but the current solution provides the best performance since joins result in additional overhead.

apps/api/src/lib/utils.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/graphql/schema/instructors.graphql Show resolved Hide resolved
libs/db/prisma/schema.prisma Show resolved Hide resolved
@ecxyzzy ecxyzzy temporarily deployed to staging-119 January 10, 2024 18:22 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119-docs January 10, 2024 18:22 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy requested a review from ap0nia January 10, 2024 18:23
ap0nia
ap0nia approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

apps/api/src/lib/utils.ts Show resolved Hide resolved
tools/registrar-scraper/src/index.ts Outdated Show resolved Hide resolved
@ecxyzzy ecxyzzy temporarily deployed to staging-119 January 16, 2024 20:15 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-119-docs January 16, 2024 20:15 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy merged commit 04cdeab into main Jan 17, 2024
5 checks passed
@ecxyzzy ecxyzzy deleted the course-instructor-previews branch January 17, 2024 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ap0nia ap0nia ap0nia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecxyzzy @ap0nia