-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Availability Tab #97
base: main
Are you sure you want to change the base?
Conversation
…' into group-availability
There's a bug where the |
@MinhxNguyen7 Group availability loads correctly now, even with multiple users. Also did some clean up by moving the personal availability parsing up to However, editing personal availability doesn't update the group availability store unless the page is reloaded. This would have to be accounted for in the future. |
@KevinWu098 Should be ready to review again. Currently, group availability works only for registered users. We can create a new issue for guests and you can look into that. Here's a sample meeting on staging that shows it working. https://staging-97.zotmeet.com/availability/7f8b2794-5605-44cb-84bd-f04fc098c705 |
Looks good on deployment -- will look over code asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just some minor nits
// @ts-expect-error slug is defined in the route | ||
const meeting_id: string = params?.slug; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// @ts-expect-error slug is defined in the route | |
const meeting_id: string = params?.slug; | |
const meeting_id: string = params?.slug ?? ""; |
chore: unused ts directive -- slug is read as any
. It might be better to use the nullish coalescing operator ??
to force it into a string
* @param meetingId | ||
* @returns a record of the member name to their availabilities, each sorted by date | ||
*/ | ||
async function getMeetingMemeberAvailabilities(meetingId: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async function getMeetingMemeberAvailabilities(meetingId: string) { | |
async function getMeetingMemberAvailabilities(meetingId: string) { |
typo: Memeber instead of Member; also change line 34 where this function is called
Description
load
, and updates thegroupAvailabilities
store.TODOs
Minimal code to create a meeting.(done in Meeting Creation Functionality #102)groupAvailabilities
store when the user changes their availability.Test Plan
Issues