-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create app drawer #12
Conversation
d6c57d7
to
910243d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks solid. Just some comments on styling and consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good except for a quick question on the sizing of the sidebar. IMO it's a little large. Thoughts? Actually, on further consideration, it's kinda growing on me.
Though I will ask about whether or not the sidebar should be right aligned in mobile view. 👀
I do agree the sidebar's a little big, but I couldn't quickly find a way to fix it, so I'm leaving that for the future. I put the sidebar on the right because I can't put the hamburger menu on the left because the icon's there, but I'm open to suggestions. Are these your only concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Styling considerations can be addressed later; LGTM
Description
Add a drawer (thing that comes in from the side) with relevant buttons and information. The drawer is a sidebar on sufficiently-side devices
Includes:
Deadline
I plan to finish this by Monday, 25 December.
TODOs