Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations #116

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Fix migrations #116

merged 6 commits into from
Jun 3, 2024

Conversation

MinhxNguyen7
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 commented Jun 3, 2024

Description

  • Add migrations to repo to keep everything in sync.
  • Add commit hook to generate and add migrations files.
  • Add commit hook to remove references to the "public" schema in migration files that Drizzle generate.
    • Not sure why Drizzle creates entities in "public" specifically, but that prevented us from using staging.
  • Throw SvelteKit errors (instead of just calling them) to get proper error messages.

Test Plan

  • Verify that meeting creation works in the deployment.
  • See that this also works on prod.

Issues

Future Follow-Up

@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 22:11 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 22:14 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-116 June 3, 2024 22:26 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 22:38 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 22:44 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 22:54 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-116 June 3, 2024 23:09 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 marked this pull request as ready for review June 3, 2024 23:14
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seancfong
Copy link
Member

@ecxyzzy @MinhxNguyen7 Meeting creation works on staging. Merging this to main to see if prod works.

@seancfong seancfong merged commit 55a7103 into main Jun 3, 2024
1 check passed
@seancfong seancfong deleted the fix-migrations branch June 3, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meeting creation doesn't work on staging
3 participants