Multiple tweaks and bugfixes #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianeicher
force-pushed
the
pull-request
branch
2 times, most recently
from
8a5b50e to
7ba118c
Compare
Closed
Contributor
Author
Contributor
|
Have you heard anything from @hempels about re-licensing his contribution? As soon as I get confirmation from him, I'll merge all of the code in. -Neil |
Otherwise we lose the additional accuracy we gain from Unix or NT timestamps. Changing DateTime externally also changes DosTime. DosTime is only mapped to DateTime once on load, if there is no Unix or NT timestamp.
Contributor
|
Approval was a bit complicated as the company I worked for when I contributed that change was subsequently acquired. |
Some rogue zip creators fail to set a non-zero local header size in Extra Data causing SharpZLib to reject them, this patch causes the library to tolerate that particular oversight like most other libraries.
bastianeicher
force-pushed
the
pull-request
branch
from
7ba118c to
3bd09a7
Compare
Contributor
Author
Contributor
|
Shawn & Bastian, Thanks for taking the extra time to square everything away, and thank you for your contributions. -Neil |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been maintaing a fork of SharpZipLib with a number of small tweaks and bugfixes. This code has been in heavy use for over a year in Zero Install and is available on NuGet as ICSharpCode.SharpZipLib.Patched.
For the pull request I have rebased everything on the current master and removed anything that would change the publicly visible API. This also includes the commit from #18, which I've been using in my fork.