fix(zip): dont fail test on 0 sizes and descriptor #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 73.82% 73.83%
=======================================
Files 68 69 +1
Lines 8353 8355 +2
=======================================
+ Hits 6167 6169 +2
Misses 2186 2186
Continue to review full report at Codecov.
|
piksel
force-pushed
the
fix/localheadertestsize64
branch
from
44d246c to
c761aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing what seems like a merge artifact (7 years ago!) that fails the
LocalHeaderTests when an archive is using Zip64 and Descriptors, and the size in the local Zip64 extra data is set to0(which is per spec).This also replaces the bitwise flag checks with a helper method to increase legibility (not mixing boolean and bitwise logic).
Fixes #735