Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zip): use ushort for ITaggedData.TagID #669

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Oct 7, 2021

This is the TagId change from #470 split into a stand alone change.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #669 (730f50f) into master (b5b1a92) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   73.07%   73.31%   +0.24%     
==========================================
  Files          68       68              
  Lines        8305     8305              
==========================================
+ Hits         6069     6089      +20     
+ Misses       2236     2216      -20     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Zip/ZipExtraData.cs 76.33% <0.00%> (ø)
...ode.SharpZipLib/Zip/Compression/DeflaterHuffman.cs 97.87% <0.00%> (+6.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b1a92...730f50f. Read the comment docs.

@piksel piksel self-assigned this Oct 8, 2021
@piksel piksel changed the title Change ITaggedData.TagID from a short to a ushort fix(zip): use ushort for ITaggedData.TagID Oct 9, 2021
@piksel piksel merged commit d34e5c9 into icsharpcode:master Oct 9, 2021
@Numpsy Numpsy deleted the rw/zip/ushort_tag branch October 9, 2021 17:00
@piksel piksel linked an issue Oct 9, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra IDs larger than short.MaxValue not supported in ZipExtraData
2 participants