Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore directory timestamps when extracting with FastZip #433

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Apr 1, 2020

When extracting a zip with FastZip with the RestoreDateTimeOnExtract set to true, restore the LastWriteTime on directories as well as files.

Only resets the timestamp on folders that it creates itself, not if extracting into an already existant folder structure.

refs #426

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Numpsy added 2 commits April 1, 2020 19:59
Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is essentially what I had in mind as well.

@piksel piksel merged commit 23841d2 into icsharpcode:master Jun 19, 2020
@Numpsy Numpsy deleted the rw/fastzip/retain_directory_time branch June 19, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants