Optimize combinators for resolved cases #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements three optimizations, for three different combinators. For Future::all, if a future is already known to be failed, we know upfront that the result will be a failed future, and we can reuse this result. For Future::after, if a future is already resolved, there is no reason to keep it in the waiting list. For Future::first, if a future is already known to be resolved, we know upfront that the result will be a resolved future, and we can reuse this result. The implementations rely on `resolved?` and `failed?`, which according to the specs are not guaranteed to exist on a future, and thus the code has to check their presence before doing anything about it.
|
Remind me to release a new version with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements three optimizations, for three different combinators.
For
Future::all, if a future is already known to be failed, we know upfront that the result will be a failed future, and we can reuse this result.For
Future::after, if a future is already resolved, there is no reason to keep it in the waiting list.For
Future::first, if a future is already known to be resolved, we know upfront that the result will be a resolved future, and we can reuse this result.The implementations rely on
resolved?andfailed?, which according to the specs are not guaranteed to exist on a future, and thus the code has to check their presence before doing anything about it.