Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fee check send message #84

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Sep 14, 2023

Description:

Commit Message

fix: fee check send message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin added the bug Something isn't working label Sep 14, 2023
@ibrizsabin ibrizsabin self-assigned this Sep 14, 2023
@ibrizsabin ibrizsabin marked this pull request as ready for review September 14, 2023 06:45
@ibrizsabin ibrizsabin linked an issue Sep 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one question

Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrizsabin ibrizsabin merged commit cfcc26a into release Sep 15, 2023
6 checks passed
@ibrizsabin ibrizsabin deleted the fix/fee-check-send-message branch September 15, 2023 05:23
redlarva added a commit that referenced this pull request Oct 4, 2023
* fix: handleMessage parameter-from to fromNid (#28)

* fix: handleMessage parameter-from to fromNid

* fix: issues fixed occured during fixes

* fix: parameter changed in rust side and docs

* style: cargo lints fixes

* chore: underscore added in parameter docs

---------

Co-authored-by: AntonAndell <[email protected]>

* fix: fee check send message (#84)

* fix: add fee check

* chore: pass build

* fix: add test for fail case

* fix: reverse fee logic

* fix: add zero check

* ci: publish xcall-multi library to maven repository (#71)

* ci: publish xcall-multi library to maven repository

* add  publish_maven.yml

* Update build.gradle

* fix maven publish 400 error, this due to initializeSonatypeStagingRepository task failed

* add workaround solution - comment maven publish block and only uncomment during publish task
 This is due to icon java plugin is only compatible with older plugin import syntax while nexus-publish plugin only works in new plugin import syntax

* add sonatype group properties variable - GROUP

* bump version - xcall-lib to 0.1.2

* docs: add maven badge and gradle implementation in README

* fix: remove unnecessary comments (#72)

* fix: remove unnecessary comment

* chore: pass build

---------

Co-authored-by: sabinchitrakar <[email protected]>

* chore: find and replace xCall -> xcall-multi in md files (#52)

* ci: enable release in an action (#103)

---------

Co-authored-by: gcranju <[email protected]>
Co-authored-by: AntonAndell <[email protected]>
Co-authored-by: ibrizsabin <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
Co-authored-by: sabinchitrakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fee check on send message to route extra fees to feehandler
3 participants