-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fee check send message #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrizsabin
requested review from
redlarva,
nightowl121 and
AntonAndell
as code owners
September 14, 2023 06:45
AntonAndell
requested changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with one question
AntonAndell
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
redlarva
added a commit
that referenced
this pull request
Oct 4, 2023
* fix: handleMessage parameter-from to fromNid (#28) * fix: handleMessage parameter-from to fromNid * fix: issues fixed occured during fixes * fix: parameter changed in rust side and docs * style: cargo lints fixes * chore: underscore added in parameter docs --------- Co-authored-by: AntonAndell <[email protected]> * fix: fee check send message (#84) * fix: add fee check * chore: pass build * fix: add test for fail case * fix: reverse fee logic * fix: add zero check * ci: publish xcall-multi library to maven repository (#71) * ci: publish xcall-multi library to maven repository * add publish_maven.yml * Update build.gradle * fix maven publish 400 error, this due to initializeSonatypeStagingRepository task failed * add workaround solution - comment maven publish block and only uncomment during publish task This is due to icon java plugin is only compatible with older plugin import syntax while nexus-publish plugin only works in new plugin import syntax * add sonatype group properties variable - GROUP * bump version - xcall-lib to 0.1.2 * docs: add maven badge and gradle implementation in README * fix: remove unnecessary comments (#72) * fix: remove unnecessary comment * chore: pass build --------- Co-authored-by: sabinchitrakar <[email protected]> * chore: find and replace xCall -> xcall-multi in md files (#52) * ci: enable release in an action (#103) --------- Co-authored-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: ibrizsabin <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: sabinchitrakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: